From: Minho Ban <mhban@samsung.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Turner <pjt@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [RFC/PATCH] Prevent wasting time to find out get_parent_ip
Date: Wed, 25 Apr 2012 08:31:24 +0900 [thread overview]
Message-ID: <4F9737CC.6010703@samsung.com> (raw)
In-Reply-To: <1335272025.28150.193.camel@twins>
On 04/24/2012 09:53 PM, Peter Zijlstra wrote:
> On Tue, 2012-04-24 at 21:36 +0900, Minho Ban wrote:
>> trace_preempt_on/off looks empty if PREEMPT_TRACER is off. But actually it is
>> spending time to find out get_parent_ip(even CALLER_ADDR for some ARCH) which is
>> in argument. This seems not fair for those who expect to do nothing but increase
>> or decrease count.
>
> You can do the same by making them CPP macros and adding a comment as to
> why they're macros instead of inlines..
>
Thank you for pointing this out, certainly macros look better. I'll amend this.
next prev parent reply other threads:[~2012-04-24 23:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 12:36 [RFC/PATCH] Prevent wasting time to find out get_parent_ip Minho Ban
2012-04-24 12:53 ` Peter Zijlstra
2012-04-24 18:18 ` Steven Rostedt
2012-04-24 23:31 ` Minho Ban [this message]
2012-04-24 23:45 ` Josh Triplett
2012-04-25 3:21 ` Minho Ban
2012-04-25 3:32 ` Steven Rostedt
2012-04-25 6:46 ` Josh Triplett
2012-04-24 18:16 ` Steven Rostedt
2012-04-24 23:54 ` Minho Ban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9737CC.6010703@samsung.com \
--to=mhban@samsung.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.