From: Kukjin Kim <kgene.kim@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
patches@linaro.org, Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH] ARM: EXYNOS: Fix compilation error when CONFIG_OF is not defined
Date: Tue, 24 Apr 2012 16:54:04 -0700 [thread overview]
Message-ID: <4F973D1C.50402@samsung.com> (raw)
In-Reply-To: <1335247608-28518-1-git-send-email-tushar.behera@linaro.org>
Tushar Behera wrote:
> Fixed following compile time error.
> arch/arm/mach-exynos/common.c: In function 'exynos5_init_irq':
> arch/arm/mach-exynos/common.c:539:2: error: implicit declaration of function 'of_irq_init'
> arch/arm/mach-exynos/common.c:539:14: error: 'exynos4_dt_irq_match' undeclared (first use in this function)
> arch/arm/mach-exynos/common.c:539:14: note: each undeclared identifier is reported only once for each function it appears in
>
> CC: Thomas Abraham<thomas.abraham@linaro.org>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> arch/arm/mach-exynos/common.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 1396c06..42de625 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -536,7 +536,9 @@ void __init exynos5_init_irq(void)
> {
> int irq;
>
> +#ifdef CONFIG_OF
> of_irq_init(exynos4_dt_irq_match);
> +#endif
>
> for (irq = 0; irq< EXYNOS5_MAX_COMBINER_NR; irq++) {
> combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq),
Yes, right. Now, we need this for exynos4 and exynos5 in mach-exynos.
Will apply, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2012-04-24 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 6:06 [PATCH] ARM: EXYNOS: Fix compilation error when CONFIG_OF is not defined Tushar Behera
2012-04-24 23:54 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F973D1C.50402@samsung.com \
--to=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.