From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH for v3.4-rc3] ARM: Samsung: add missing MMC_CAP2_BROKEN_VOLTAGE capability Date: Tue, 24 Apr 2012 17:33:12 -0700 Message-ID: <4F974648.6020702@samsung.com> References: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:39385 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756096Ab2DYAdP (ORCPT ); Tue, 24 Apr 2012 20:33:15 -0400 Received: by pbbro12 with SMTP id ro12so748040pbb.19 for ; Tue, 24 Apr 2012 17:33:15 -0700 (PDT) In-Reply-To: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kyungmin Park , Jaehoon Chung , Kukjin Kim Marek Szyprowski wrote: > Commit 6e8201f57c935 "mmc: core: add the capability for broken voltage" > introduced a new quirk to indicate that MMC core should ignore voltage > change errors reported by the regulators core. This is required to get > SDHCI working on UniversalC210, NURI and GONI boards again after commit > ceb6143b2df81c ("mmc: sdhci: fix vmmc handling"). > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/mach-nuri.c | 1 + > arch/arm/mach-exynos/mach-universal_c210.c | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 2 ++ > 3 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c > index 91e5986..021dc68 100644 > --- a/arch/arm/mach-exynos/mach-nuri.c > +++ b/arch/arm/mach-exynos/mach-nuri.c > @@ -112,6 +112,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data __initdata = { > .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA | > MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | > MMC_CAP_ERASE), > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > > diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c > index ef706e9..add55b4 100644 > --- a/arch/arm/mach-exynos/mach-universal_c210.c > +++ b/arch/arm/mach-exynos/mach-universal_c210.c > @@ -747,6 +747,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data __initdata = { > .max_width = 8, > .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA | > MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED), > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c > index a8933de..3239566 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -765,6 +766,7 @@ static void __init goni_pmic_init(void) > /* MoviNAND */ > static struct s3c_sdhci_platdata goni_hsmmc0_data __initdata = { > .max_width = 4, > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 24 Apr 2012 17:33:12 -0700 Subject: [PATCH for v3.4-rc3] ARM: Samsung: add missing MMC_CAP2_BROKEN_VOLTAGE capability In-Reply-To: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com> References: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com> Message-ID: <4F974648.6020702@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marek Szyprowski wrote: > Commit 6e8201f57c935 "mmc: core: add the capability for broken voltage" > introduced a new quirk to indicate that MMC core should ignore voltage > change errors reported by the regulators core. This is required to get > SDHCI working on UniversalC210, NURI and GONI boards again after commit > ceb6143b2df81c ("mmc: sdhci: fix vmmc handling"). > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/mach-nuri.c | 1 + > arch/arm/mach-exynos/mach-universal_c210.c | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 2 ++ > 3 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c > index 91e5986..021dc68 100644 > --- a/arch/arm/mach-exynos/mach-nuri.c > +++ b/arch/arm/mach-exynos/mach-nuri.c > @@ -112,6 +112,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data __initdata = { > .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA | > MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | > MMC_CAP_ERASE), > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > > diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c > index ef706e9..add55b4 100644 > --- a/arch/arm/mach-exynos/mach-universal_c210.c > +++ b/arch/arm/mach-exynos/mach-universal_c210.c > @@ -747,6 +747,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data __initdata = { > .max_width = 8, > .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA | > MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED), > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c > index a8933de..3239566 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -765,6 +766,7 @@ static void __init goni_pmic_init(void) > /* MoviNAND */ > static struct s3c_sdhci_platdata goni_hsmmc0_data __initdata = { > .max_width = 4, > + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE, > .cd_type = S3C_SDHCI_CD_PERMANENT, > }; > OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.