Re: [PATCH 01/10] OMAPDSS: HDMI: Remove ASoC codec

[Ricardo Neri <ricardo.neri@ti.com>]

Hi Tomi,

Thanks for your comments!

On 04/23/2012 08:17 AM, Tomi Valkeinen wrote:
> On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote:
>> Instead of having an ASoC codec embedded into DSS code, use the generic DSS
>> device driverinterface for audio support. This allows to any potential user,
>> including an ASoC driver, take advantage of the HDMI audio functionality.
>
> The description could be improved. The patch removes lots of code from
> the hdmi driver, but the description doesn't really describe what's
> going on and where the code goes (if anywhere). In fact, it even feels
> that the description is about something else. It basically just says
> "use generic DSS interface for audio", but the patch doesn't do that, it
> removes code.

Yes. It seems that the description is more suitable for the whole patch 
series. I was trying to justify why I was removing the ASoC HDMI codec. 
I will rephrase to state that this patch removes the HDMI audio support 
to restore in a separate patch through the DSS audio interface.
>
> Also how does this affect the current driver? I presume it effectively
> removes HDMI audio support? Does the code still compile with this patch?

Yes, the code still compiles as the current ASoC HDMI codec exists with 
independences of the ASoC HDMI DAI and machine drivers. It will compile 
but it will not probe and ALSA HDMI audio support will be missing.

BR,

Ricardo
>
>   Tomi