All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] wpa_supplicant: install basic configuration file
Date: Wed, 25 Apr 2012 08:23:11 +0200	[thread overview]
Message-ID: <4F97984F.4000809@visionsystems.de> (raw)
In-Reply-To: <87pqawga6d.fsf@macbook.be.48ers.dk>

Am 24.04.2012 22:13, schrieb Peter Korsgaard:
>>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:
> 
>  yegorslists> From: Yegor Yefremov <yegorslists@googlemail.com>
>  yegorslists> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>  yegorslists> ---
>  yegorslists>  package/wpa_supplicant/wpa_supplicant.conf |    6 ++++++
>  yegorslists>  package/wpa_supplicant/wpa_supplicant.mk   |    8 ++++++++
>  yegorslists>  2 files changed, 14 insertions(+), 0 deletions(-)
>  yegorslists>  create mode 100755 package/wpa_supplicant/wpa_supplicant.conf
> 
>  
>  yegorslists> +define WPA_SUPPLICANT_INSTALL_CONFIG
>  yegorslists> +	$(INSTALL) -m 644 \
>  yegorslists> +	  package/wpa_supplicant/wpa_supplicant.conf  $(TARGET_DIR)/etc/wpa_supplicant.conf
> 
> Normally we only install these default files if not already present in
> the rootfs, so people can put their own version in the skeleton if they
> need something else. See ifplugd for an example.
> 
>  yegorslists> +
>  yegorslists>  define WPA_SUPPLICANT_UNINSTALL_TARGET_CMDS
>  yegorslists>  	rm -f $(addprefix $(TARGET_DIR)/usr/sbin/, $(WPA_SUPPLICANT_TARGET_BINS))
>  yegorslists>  	rm -f $(TARGET_DIR)/etc/dbus-1/system.d/wpa_supplicant.conf
>  yegorslists>  	rm -f $(TARGET_DIR)/usr/share/dbus-1/system-services/$(WPA_SUPPLICANT_DBUS_SERVICE).service
>  yegorslists> +	rm -f $(TARGET_DIR)/usr/etc/wpa_supplicant.conf
> 
> This doesn't work so well when you add the check before installation as
> adding/removing/adding wpasupplicant again would then overwrite the
> skeleton one. I suggest you just skip this.

Should I just this file to default skeleton or drop it completely, so that user would supply it via custom script?

Yegor

  parent reply	other threads:[~2012-04-25  6:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  6:55 [Buildroot] [PATCH v2 1/2] wpa_supplicant: install basic configuration file yegorslists at googlemail.com
2012-04-23  6:55 ` [Buildroot] [PATCH v2 2/2] dbus: bump to 1.4.20 yegorslists at googlemail.com
2012-04-24 20:09   ` Peter Korsgaard
2012-04-24 20:13 ` [Buildroot] [PATCH v2 1/2] wpa_supplicant: install basic configuration file Peter Korsgaard
2012-04-24 22:03   ` Thomas Petazzoni
2012-04-25  6:23   ` Yegor Yefremov [this message]
2012-05-09 20:37 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F97984F.4000809@visionsystems.de \
    --to=yegor_sub1@visionsystems.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.