From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 5/5] mfd: twl6040-core: Convert to devm_regmap_init_i2c()
Date: Wed, 25 Apr 2012 09:33:18 +0300 [thread overview]
Message-ID: <4F979AAE.6010902@ti.com> (raw)
In-Reply-To: <1335319786.30909.11.camel@phoenix>
On 04/25/2012 05:09 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/twl6040-core.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c
> index 2d6beda..493f4a6 100644
> --- a/drivers/mfd/twl6040-core.c
> +++ b/drivers/mfd/twl6040-core.c
> @@ -524,7 +524,7 @@ static int __devinit twl6040_probe(struct i2c_client *client,
> goto err;
> }
>
> - twl6040->regmap = regmap_init_i2c(client, &twl6040_regmap_config);
> + twl6040->regmap = devm_regmap_init_i2c(client, &twl6040_regmap_config);
> if (IS_ERR(twl6040->regmap)) {
> ret = PTR_ERR(twl6040->regmap);
> goto err;
> @@ -623,7 +623,6 @@ gpio2_err:
> gpio_free(twl6040->audpwron);
> gpio1_err:
> i2c_set_clientdata(client, NULL);
> - regmap_exit(twl6040->regmap);
> err:
> return ret;
> }
> @@ -643,7 +642,6 @@ static int __devexit twl6040_remove(struct i2c_client *client)
>
> mfd_remove_devices(&client->dev);
> i2c_set_clientdata(client, NULL);
> - regmap_exit(twl6040->regmap);
>
> return 0;
> }
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
next prev parent reply other threads:[~2012-04-25 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 2:01 [PATCH 1/5] mfd: rc5t583: Convert to devm_regmap_init_i2c() Axel Lin
2012-04-25 2:03 ` [PATCH 2/5] mfd: s5m-core: " Axel Lin
2012-04-25 2:04 ` [PATCH 3/5] mfd: tps65090: " Axel Lin
2012-04-25 5:20 ` Venu Byravarasu
2012-04-25 2:06 ` [PATCH 4/5] mfd: tps65217: " Axel Lin
2012-04-25 2:09 ` [PATCH 5/5] mfd: twl6040-core: " Axel Lin
2012-04-25 6:33 ` Peter Ujfalusi [this message]
2012-04-25 7:12 ` [PATCH 1/5] mfd: rc5t583: " Laxman Dewangan
2012-05-09 15:53 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F979AAE.6010902@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.