From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Dong Aisheng
<dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC] pinctrl: enhance reporting of errors when loading from DT
Date: Wed, 25 Apr 2012 13:16:21 +0200 [thread overview]
Message-ID: <4F97DD05.90207@openwrt.org> (raw)
In-Reply-To: <CACRpkdZZALK3ZYkMjx1LfBryVuKOSVvRX8OZX-Vv1OPTAmWGyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Linus
>> There are a few places tagged with //FIXME.
> No C99 comments. See Documentation/CodingStyle.
the //FIXME bits are as described below the tear line only there to show
which places I checked. they obviously will be removed in the final patch
> So if you're gonna keep them,
> /* use plain C comments */
>
> And follow up on Stephens comments...
i will follow up on stephens comments asap ...
John
next prev parent reply other threads:[~2012-04-25 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 16:53 [RFC] pinctrl: enhance reporting of errors when loading from DT John Crispin
[not found] ` <1335286387-18520-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-04-25 2:45 ` Stephen Warren
[not found] ` <4F976554.3090708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-25 11:27 ` John Crispin
2012-04-25 11:13 ` Linus Walleij
[not found] ` <CACRpkdZZALK3ZYkMjx1LfBryVuKOSVvRX8OZX-Vv1OPTAmWGyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-25 11:16 ` John Crispin [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 14:43 John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97DD05.90207@openwrt.org \
--to=blogic-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.