From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Subject: Re: [PATCH 06/26] drm/radeon: fix a critical bug in the SA code
Date: Wed, 25 Apr 2012 17:38:01 +0200
Message-ID: <4F981A59.2010001@vodafone.de>
References: <1335358003-2987-1-git-send-email-deathsimple@vodafone.de>
	<1335358003-2987-7-git-send-email-deathsimple@vodafone.de>
	<1335359986.19225.21.camel@thor.local>
	<CADnq5_Pkc2BOO5HT3CAZKVaLWq6pryt1ec8_VaVrfd3WRdzcvg@mail.gmail.com>
	<CAH3drwbXi9V6CP8PYDpTtOKiX1Gm1VCbUAVE3jLWVqRbfQLMUA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de
	[139.7.28.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 821B1A0D52
	for <dri-devel@lists.freedesktop.org>;
	Wed, 25 Apr 2012 08:38:05 -0700 (PDT)
In-Reply-To: <CAH3drwbXi9V6CP8PYDpTtOKiX1Gm1VCbUAVE3jLWVqRbfQLMUA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Jerome Glisse <j.glisse@gmail.com>
Cc: =?ISO-8859-1?Q?r?= <michel@daenzer.net>, dri-devel@lists.freedesktop.org, =?ISO-8859-1?Q?Michel_D=E4nze?=@freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 25.04.2012 16:34, Jerome Glisse wrote:
> On Wed, Apr 25, 2012 at 9:40 AM, Alex Deucher<alexdeucher@gmail.com>  wro=
te:
>> On Wed, Apr 25, 2012 at 9:19 AM, Michel D=E4nzer<michel@daenzer.net>  wr=
ote:
>>> On Mit, 2012-04-25 at 14:46 +0200, Christian K=F6nig wrote:
>>>> Aligning offset can make it bigger than tmp->offset
>>>> leading to an overrun bug in the following subtraction.
>>>>
>>>> Signed-off-by: Christian K=F6nig<deathsimple@vodafone.de>
>>> Please add
>>>
>>> Cc: stable@vger.kernel.org
>>>
>>> to the commit log (but don't send the patch to that address during
>>> review). That way, once Linus merges the fix, it'll be picked up for the
>>> 3.3.y stable tree.
>>>
>>> With that addition,
>>>
>>> Reviewed-by: Michel D=E4nzer<michel.daenzer@amd.com>
>> Reviewed-by: Alex Deucher<alexander.deucher@amd.com>
>>
>> This should probably go in now via drm-fixes (with stable cced).  Might =
fix:
>> https://bugs.freedesktop.org/show_bug.cgi?id=3D45018
>>
>> Alex
> I don't think this patch fix anything, as up until now they all used
> same alignment.
Correct, as I allready mentioned in the other mail: The VM code and the =

IB code do use different alignments, but they also use different =

instances of SA manager. So that problem won't hurt us in the current =

mainline.

Christian.