From: Rik van Riel <riel@redhat.com>
To: Ying Han <yinghan@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] rename is_mlocked_vma() to mlocked_vma_newpage()
Date: Wed, 25 Apr 2012 14:05:37 -0400 [thread overview]
Message-ID: <4F983CF1.2060800@redhat.com> (raw)
In-Reply-To: <1335375955-32037-1-git-send-email-yinghan@google.com>
On 04/25/2012 01:45 PM, Ying Han wrote:
> Andrew pointed out that the is_mlocked_vma() is misnamed. A function
> with name like that would expect bool return and no side-effects.
>
> Since it is called on the fault path for new page, rename it in this
> patch.
>
> Signed-off-by: Ying Han<yinghan@google.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-25 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 17:45 [PATCH] rename is_mlocked_vma() to mlocked_vma_newpage() Ying Han
2012-04-25 18:05 ` Rik van Riel [this message]
2012-04-25 18:54 ` KOSAKI Motohiro
2012-04-26 0:03 ` KAMEZAWA Hiroyuki
2012-04-26 5:17 ` Minchan Kim
2012-04-26 17:50 ` Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F983CF1.2060800@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.