All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Matthew Wilcox <matthew.wilcox@linux.intel.com>,
	Don Dutile <ddutile@redhat.com>, Myron Stowe <mstowe@redhat.com>,
	James Paradis <james.paradis@stratus.com>
Subject: Re: [PATCH v1] PCI: work around Stratus ftServer broken PCIe hierarchy
Date: Thu, 26 Apr 2012 08:24:09 -0400	[thread overview]
Message-ID: <4F993E69.1010309@redhat.com> (raw)
In-Reply-To: <20120425233632.12292.32916.stgit@bhelgaas.mtv.corp.google.com>



On 04/25/2012 07:36 PM, Bjorn Helgaas wrote:
> A PCIe downstream port is a P2P bridge.  Its secondary interface is
> a link that should lead only to device 0 (unless ARI is enabled)[1], so
> we don't probe for non-zero device numbers.
> 
> Some Stratus ftServer systems have a PCIe downstream port (02:00.0) that
> leads to both an upstream port (03:00.0) and a downstream port (03:01.0),
> and 03:01.0 has important devices below it:
> 
>   [0000:02]-+-00.0-[0000:03]--+-00.0
>                               \-01.0-[0000:xx]--+-[USB]
>                                                 \-[NIC]
> 
> Previously, we didn't enumerate device 03:01.0, so USB and the network
> didn't work.  This patch adds a DMI quirk to scan all device numbers,
> not just 0, below a downstream port.
> 
> Based on a patch by Prarit Bhargava.
> 
> [1] PCIe spec r3.0, sec 7.3.1
> 
> CC: Myron Stowe <mstowe@redhat.com>
> CC: Don Dutile <ddutile@redhat.com>
> CC: James Paradis <jim.paradis@stratus.com>

Nuts.  This is my fault.  I'm so used to calling him "Jim" that I screwed up his
email address.  It should be james.paradis@stratus.com .

Jim, can you retest with this updated version of the patch so we can confirm it
works?

http://marc.info/?l=linux-pci&m=133539711207345&w=2

Thanks,

P.

  parent reply	other threads:[~2012-04-26 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 23:36 [PATCH v1] PCI: work around Stratus ftServer broken PCIe hierarchy Bjorn Helgaas
2012-04-26  0:30 ` Yinghai Lu
2012-04-26 12:29   ` Prarit Bhargava
2012-04-26 14:41     ` Bjorn Helgaas
2012-04-26 12:24 ` Prarit Bhargava [this message]
2012-04-27  3:35 ` Wei Yang
2012-04-27 14:21   ` Bjorn Helgaas
2012-04-28 19:26 ` Matthew Wilcox
2012-04-30 21:38   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F993E69.1010309@redhat.com \
    --to=prarit@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=ddutile@redhat.com \
    --cc=james.paradis@stratus.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.wilcox@linux.intel.com \
    --cc=mstowe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.