Re: Test result of xen-unstable changeset 25249

[George Dunlap <george.dunlap@eu.citrix.com>]

On 27/04/12 09:21, Dieter Bloms wrote:
> yes, this is an issue with my patch :( All default values has to be 0, 
> but only for the credit(2) scheduler cpu_weight must not. So I made a 
> patch, which set a default of 256 when the cpu_weight isn't set and 
> credit(2) is used and let it 0 when the scheduler sedf is used. Please 
> try the attached patch and see if it solve this issue. 
Dieter,

Thanks for the patch.  However, I'd really rather avoid putting 
scheduler defaults in xl if we can at all avoid it.  Defaults should be 
set in one place, and that should be in the scheduling code itself.

I think what we really want to do is is any of the parameters are set, 
after the domain is first created, to read the scheduling parameters for 
the domain (which will be the defaults), change the ones that are set in 
the config file, and then write the whole structure back.  That 
shouldn't be too hard, as libxl__sched_set_params() is called after the 
domain itself is created; the main thing is how to tell 
libxl__sched_set_params() which parameters actually need to be set, and 
which should be left alone.

Are you up for doing that?  If not, I can put it on my to-do list.

Thanks,
  -George