Re: [PATCH 6/8] ASoC: Ux500: Add platform-driver

[Ola Lilja <ola.o.lilja@stericsson.com>]

On 04/23/2012 08:31 PM, Mark Brown wrote:

> On Fri, Apr 20, 2012 at 11:33:14AM +0200, Ola Lilja wrote:
>> Add platform-driver handling all DMA-activities.
> 
> Overall this looks really good, but it depends on the stream print thing
> as well.  There's a few very nitpicky issues also:
> 
>> -config SND_SOC_UX500_MSP_I2S
>> +config SND_SOC_UX500_PLAT_MSP_I2S
> 
> Should be in the previous patch.


True.

> 
>> -snd-soc-ux500-msp-i2s-objs := ux500_msp_dai.o ux500_msp_i2s.o
>> -obj-$(CONFIG_SND_SOC_UX500_MSP_I2S) += snd-soc-ux500-msp-i2s.o
>> +snd-soc-ux500-plat-msp-i2s-objs := ux500_msp_dai.o ux500_msp_i2s.o
>> +obj-$(CONFIG_SND_SOC_UX500_PLAT_MSP_I2S) += snd-soc-ux500-plat-msp-i2s.o
> 
> Likewise.


True.

> 
>> +	dev_dbg(dev, "%s: Init runtime private data.\n", __func__);
>> +	ux500_pcm_data = kzalloc(sizeof(struct ux500_pcm), GFP_KERNEL);
>> +	if (ux500_pcm_data == NULL)
>> +		return -ENOMEM;
>> +	ux500_pcm_data->msp_id = dai->id;
> 
> devm_kzalloc()?


I will change.