From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: davinci: pdctl next bit position incorrect
Date: Fri, 27 Apr 2012 14:12:53 +0400 [thread overview]
Message-ID: <4F9A7125.6050802@mvista.com> (raw)
In-Reply-To: <4F99870A.6080201@ti.com>
Hello.
On 26-04-2012 21:34, Sekhar Nori wrote:
>> On 04/19/2012 08:52 PM, Sekhar Nori wrote:
>>>>>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>>>>>> patch fixes this issue
>>>>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>>>>> Applying this for v3.5.
>>>> But why not to 3.4? It concerns turning on DSP domain on DM644x.
>>> Yes, but I think as you noted sometime before, no one is really
>>> depending on kernel to turn on DSP domain on DM644x.
>> Looks like you're right (though I don't remember noting it :-).
>>> Its probably being
>>> done from U-Boot or ROM code. This is not a v3.4 regression either.
>> U-Boot does it only when DSPLINK support is not desired.
> Okay. Since DSPLink existed long before this code to turn on domain was
> introduced by Murali,
The code to turn on DSP domain wasn't introduced by Murali, it was there
originally. Ah, you probably mean that the code was checking PDSTAT0, not
PDSTAT1 before doing the DSP domain switch?
> it must be having its own private code to do this.
> So, looks like this should not really be a regression for anyone.
It seems you're right.
> Thanks,
> Sekhar
WBR, Sergei
prev parent reply other threads:[~2012-04-27 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334745664-19275-1-git-send-email-m-karicheri2@ti.com>
2012-04-18 20:23 ` [PATCH] arm: davinci: pdctl next bit position incorrect Sekhar Nori
2012-04-19 10:45 ` Sergei Shtylyov
2012-04-19 16:52 ` Sekhar Nori
2012-04-20 15:09 ` Sergei Shtylyov
2012-04-26 17:34 ` Sekhar Nori
2012-04-27 10:12 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9A7125.6050802@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.