From: Ken Werner <ken.werner@linaro.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Qt 4.8 GCC 4.7 fixes
Date: Fri, 27 Apr 2012 18:19:05 +0200 [thread overview]
Message-ID: <4F9AC6F9.5010608@linaro.org> (raw)
In-Reply-To: <1335526116.20130.67.camel@ted>
On 04/27/2012 01:28 PM, Richard Purdie wrote:
> On Fri, 2012-04-27 at 12:59 +0200, Ken Werner wrote:
>> This change introduces two new patches to Qt 4.8. One prevents the build
>> system from using the -fuse-ld=gold GCC flag as this isn't upstream and
>> therefore not supported by many toolchains out there. The second patch
>> fixes a compile time error when using toolchains based on GCC 4.7.
>>
>> Signed-off-by: Ken Werner<ken.werner@linaro.org>
>> ---
>> meta/recipes-qt/qt4/qt-4.8.1.inc | 2 +
>> .../qt4/qt-4.8.1/disable-fuse-gold-flag.patch | 26 ++++++++++++++++
>> meta/recipes-qt/qt4/qt-4.8.1/gcc47-fix.patch | 31 ++++++++++++++++++++
>> meta/recipes-qt/qt4/qt4-embedded.inc | 2 +-
>> 4 files changed, 60 insertions(+), 1 deletions(-)
>> create mode 100644 meta/recipes-qt/qt4/qt-4.8.1/disable-fuse-gold-flag.patch
>> create mode 100644 meta/recipes-qt/qt4/qt-4.8.1/gcc47-fix.patch
>
> Thanks, this is very timely as it happens.
>
> In the future could you put an "Upstream-Status:" header in any patches
> which get added along with an indication of the author? This helps a lot
> when you look at the patch in 12 months and wonder who wrote it (you
> covered why) and also gives us an idea of which patches might be worth
> prioritising to discuss with upstream.
>
> In this case, I've added your changes to master-next and added in the
> missing patch header pieces myself. I've just been working through the
> remaining gcc 4.7 issues and this looks like the main one left.
>
> Cheers,
>
> Richard
Ok, thanks!
Regards,
Ken
next prev parent reply other threads:[~2012-04-27 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 10:59 [PATCH] Qt 4.8 GCC 4.7 fixes Ken Werner
2012-04-27 11:28 ` Richard Purdie
2012-04-27 14:43 ` Khem Raj
2012-04-27 16:19 ` Ken Werner [this message]
2012-04-27 12:53 ` Eric Bénard
2012-04-27 16:19 ` Ken Werner
2012-05-01 18:53 ` Saul Wold
2012-05-01 18:55 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9AC6F9.5010608@linaro.org \
--to=ken.werner@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.