From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [next][PATCH 0/5] radeon HDMI cleaning Date: Sun, 29 Apr 2012 14:26:00 +0200 Message-ID: <4F9D3358.8060702@vodafone.de> References: <1335648924-3754-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1978193276==" Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F5DC9E7E8 for ; Sun, 29 Apr 2012 05:26:05 -0700 (PDT) In-Reply-To: <1335648924-3754-1-git-send-email-zajec5@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1978193276== Content-Type: multipart/alternative; boundary="------------070205050403080808070004" This is a multi-part message in MIME format. --------------070205050403080808070004 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 28.04.2012 23:35, Rafa=C5=82 Mi=C5=82ecki wrote: > That's my patchset making use of gained knowledge and released regs > names. This is generally just cleaning currect stuff, changing offsets > to relative ones (so we can use official regs now). > > This patch adds temp hack for Evergreen changing offset by 0x3d0. This > may look a little ugly, but it's safe and will be removed anyway. It's > here just to don't add regression in Evergreen support. > > My plan is to make use of Alex's WIP patch and add new file/code for > DCE4 (Evergreen). That will allow us to correctly use Evergreen regs > and drop thet 0x3d0 trick. > > Patchset tested on RV620 and HD6320 (so both: R6xx and Evergreen). > > Rafa=C5=82 Mi=C5=82ecki (5): > drm/radeon/kms: move audio params to separated struct > drm/radeon/kms: get rid of hdmi_config_offset > drm/radeon/kms: get rid of r600_hdmi_find_free_block > drm/radeon/kms: keep HDMI state in separated variable > drm/radeon/kms/hdmi: use relative offsets, official regs > > drivers/gpu/drm/radeon/evergreen_reg.h | 2 - > drivers/gpu/drm/radeon/r600.c | 28 +++--- > drivers/gpu/drm/radeon/r600_audio.c | 34 ++++---- > drivers/gpu/drm/radeon/r600_hdmi.c | 153 +++++++++++++----------= --------- > drivers/gpu/drm/radeon/r600_reg.h | 41 --------- > drivers/gpu/drm/radeon/r600d.h | 7 +- > drivers/gpu/drm/radeon/radeon.h | 19 ++-- > drivers/gpu/drm/radeon/radeon_mode.h | 2 +- > 8 files changed, 109 insertions(+), 177 deletions(-) > Looks good to me and also just tested on my RV710. So both: /Tested-by: //Christian K=C3=B6nig / /Reviewed-by: Christian K=C3=B6nig /// --------------070205050403080808070004 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 28.04.2012 23:35, Rafa=C5=82 Mi=C5=82ecki wrote:

That's my patchset making use of gained knowledge an=
d released regs
names. This is generally just cleaning currect stuff, changing offsets
to relative ones (so we can use official regs now).

This patch adds temp hack for Evergreen changing offset by 0x3d0. This
may look a little ugly, but it's safe and will be removed anyway. It's
here just to don't add regression in Evergreen support.

My plan is to make use of Alex's WIP patch and add new file/code for
DCE4 (Evergreen). That will allow us to correctly use Evergreen regs
and drop thet 0x3d0 trick.

Patchset tested on RV620 and HD6320 (so both: R6xx and Evergreen).

Rafa=C5=82 Mi=C5=82ecki (5):
  drm/radeon/kms: move audio params to separated struct
  drm/radeon/kms: get rid of hdmi_config_offset
  drm/radeon/kms: get rid of r600_hdmi_find_free_block
  drm/radeon/kms: keep HDMI state in separated variable
  drm/radeon/kms/hdmi: use relative offsets, official regs

 drivers/gpu/drm/radeon/evergreen_reg.h |    2 -
 drivers/gpu/drm/radeon/r600.c          |   28 +++---
 drivers/gpu/drm/radeon/r600_audio.c    |   34 ++++----
 drivers/gpu/drm/radeon/r600_hdmi.c     |  153 +++++++++++++-------------=
------
 drivers/gpu/drm/radeon/r600_reg.h      |   41 ---------
 drivers/gpu/drm/radeon/r600d.h         |    7 +-
 drivers/gpu/drm/radeon/radeon.h        |   19 ++--
 drivers/gpu/drm/radeon/radeon_mode.h   |    2 +-
 8 files changed, 109 insertions(+), 177 deletions(-)

Looks good to me and also just tested on my RV710.

So both:

Tested-by: Christian K=C3=B6nig <deathsimple@vodafone.de>
Reviewed-by: Christian K=C3=B6nig <deathsimple@vodafone.de>= ;
--------------070205050403080808070004-- --===============1978193276== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1978193276==--