From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SOapD-0002Y3-U0 for mharc-grub-devel@gnu.org; Sun, 29 Apr 2012 16:34:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOapB-0002Xx-Ri for grub-devel@gnu.org; Sun, 29 Apr 2012 16:34:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOapA-0006FU-1t for grub-devel@gnu.org; Sun, 29 Apr 2012 16:34:29 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOap9-0006Bi-Oz for grub-devel@gnu.org; Sun, 29 Apr 2012 16:34:27 -0400 Received: by wibhj13 with SMTP id hj13so1673377wib.12 for ; Sun, 29 Apr 2012 13:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=Z3++UvrZcwrHCe1yuJaTRWf/GeTndGztEhSWR7VOyug=; b=IwcHW8VAGC4puhHnm1/ZSqMogPUfN13OPQzTwhNoCtZgxMxU03sKfdknGKzWkVKfn6 9OZ6lRvM/27/8xwludqJtjmq3Mnr0oyHvrPGN06VQOPNlQ241WqhvH6O3fIY+cdxRKmZ LWvwUqtoBwwvK/00jX/9JwTggFPUkmrbs4fXEspjmiPUzz/BW7ifukP0ptVbkHklG8n5 kfDCCB3dlnGrFf5a6PvSkrNiAx1HQ+2GHEXC6j7zBQ9qkHvT9t9yH0HPEHqVZrc7Gm9B /YnfRASholU8lmV0nZjqCIIMA3gJ9idJGeI2rNr34lWpbJ0oc1H26mEwear1XwjcUG5l kEKw== Received: by 10.180.103.35 with SMTP id ft3mr12937018wib.0.1335731339983; Sun, 29 Apr 2012 13:28:59 -0700 (PDT) Received: from debian.x201.phnet (226-72.76-83.cust.bluewin.ch. [83.76.72.226]) by mx.google.com with ESMTPS id u9sm23409303wix.0.2012.04.29.13.28.57 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Apr 2012 13:28:59 -0700 (PDT) Message-ID: <4F9DA484.501@gmail.com> Date: Sun, 29 Apr 2012 22:28:52 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] New command testspeed References: <4F9D5FE6.9040909@gmail.com> <4F9DA343.5000708@gmail.com> In-Reply-To: <4F9DA343.5000708@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8E5A4E82E4253247B466EE4C" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.171 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2012 20:34:31 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8E5A4E82E4253247B466EE4C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.04.2012 22:23, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 29.04.2012 22:09, Bean wrote: >> Hi, >> >> Pls check out this one. > In terms of decreasing code duplication it doesn't improve at all. The > prefix-chosing code needs to be put into a separate function which woul= d > be used by both instances. E.g. #define GRUB_HUMAN_SIZE_MAX_LEN sizeof ("XXXXXXXXXXXXXXXXXXXX TiB") void grub_huma_size_make_size (char *res, grub_disk_addr_t sz); --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8E5A4E82E4253247B466EE4C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+dpIQACgkQNak7dOguQglF6QD/SXmSVOPgy+28YZj8jj943J/y zYv+2evxZLO9V3lZvTUA/RQbMbDtxwRASI0OQ3vQSxGc8lQEly0r9mZx2zo5+ca6 =zjTN -----END PGP SIGNATURE----- --------------enig8E5A4E82E4253247B466EE4C--