From: Felix Fietkau <nbd@openwrt.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: fix BSS comparison
Date: Mon, 30 Apr 2012 10:09:49 +0200 [thread overview]
Message-ID: <4F9E48CD.10800@openwrt.org> (raw)
In-Reply-To: <1335770616-12695-1-git-send-email-emmanuel.grumbach@intel.com>
On 2012-04-30 9:23 AM, Emmanuel Grumbach wrote:
> Since the BSS table is organized in a RB tree, the BSSs need to be
> comparable. This means that we must define a < and > operator to
> the BSS object.
> compare_ethr_addr isn't enough since it returns only a binary value.
>
> Since Felix's
>
> cfg80211: use compare_ether_addr on MAC addresses instead of memcmp
>
> Because of the constant size and guaranteed 16 bit alignment, the inline
> compare_ether_addr function is much cheaper than calling memcmp.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> The BSS table is corrupted: rb_find_bss can't find the bss.
> As a result BSSes are duplicated in the BSS table, and we get stuck
> while probing an AP before associating (in STA mode).
>
> Change-Id: I85928756f4328028230832c1565ece7f412f3843
> CC: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Looks good, thanks for finding this.
Acked-by: Felix Fietkau <nbd@openwrt.org>
prev parent reply other threads:[~2012-04-30 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 7:23 [PATCH v2] cfg80211: fix BSS comparison Emmanuel Grumbach
2012-04-30 8:09 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9E48CD.10800@openwrt.org \
--to=nbd@openwrt.org \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.