From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings
Date: Mon, 30 Apr 2012 06:33:01 -0700 [thread overview]
Message-ID: <4F9E948D.4070705@boundarydevices.com> (raw)
In-Reply-To: <201204300427.59892.marex@denx.de>
Hi Marek,
On 04/29/2012 07:27 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>>
>> ---
>> V2 has been stripped of the board-independent changes and
>> uses clrsetbits_le32() instead of twiddling bits by hand.
>>
>> <snip>
>>
>> +int setup_sata(void)
>> +{
>> + struct iomuxc_base_regs *const iomuxc_regs
>> + = (struct iomuxc_base_regs *) IOMUXC_BASE_ADDR;
>> + int rval = enable_sata_clock();
>> + if (rval)
>> + return rval ;
>
> Can you keep the return<val>; consistent with the rest of the file? (so avoid
> return<val>[space];) ... I dunno if this violates some coding style document
> though. Just a nitpick.
>
Can do. I'll update this in V4.
prev parent reply other threads:[~2012-04-30 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-March/120150.html>
2012-04-25 23:50 ` [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings Eric Nelson
2012-04-28 14:51 ` Dirk Behme
2012-04-28 15:36 ` Eric Nelson
2012-04-29 14:48 ` Stefano Babic
2012-04-30 2:27 ` Marek Vasut
2012-04-30 13:33 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9E948D.4070705@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.