From: Bryan Schumaker <bjschuma@netapp.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: linux-nfs@vger.kernel.org, Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH v3 25/25] NFS: rewrite directio write to use async coalesce code
Date: Mon, 30 Apr 2012 12:10:58 -0400 [thread overview]
Message-ID: <4F9EB992.9040501@netapp.com> (raw)
In-Reply-To: <1334947677-28864-26-git-send-email-iisaman@netapp.com>
Hi Fred,
On 04/20/2012 02:47 PM, Fred Isaman wrote:
> This also has the advantage that it allows directio to use pnfs.
>
> Signed-off-by: Fred Isaman <iisaman@netapp.com>
> ---
> fs/nfs/direct.c | 527 +++++++++++++++++++++--------------------------
> fs/nfs/internal.h | 18 ++-
> fs/nfs/nfs4filelayout.c | 44 ++++-
> fs/nfs/pnfs.h | 17 ++
> fs/nfs/write.c | 36 ++--
> 5 files changed, 319 insertions(+), 323 deletions(-)
>
> diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> index 4ba9a2c..d44de2f 100644
> --- a/fs/nfs/direct.c
> +++ b/fs/nfs/direct.c
> @@ -56,6 +56,7 @@
>
> #include "internal.h"
> #include "iostat.h"
> +#include "pnfs.h"
>
> #define NFSDBG_FACILITY NFSDBG_VFS
>
> @@ -81,16 +82,19 @@ struct nfs_direct_req {
> struct completion completion; /* wait for i/o completion */
>
> /* commit state */
> - struct list_head rewrite_list; /* saved nfs_write_data structs */
> - struct nfs_commit_data *commit_data; /* special write_data for commits */
> + struct nfs_mds_commit_info mds_cinfo; /* Storage for cinfo */
> + struct pnfs_ds_commit_info ds_cinfo; /* Storage for cinfo */
When I compile without CONFIG_NFS_V4 enabled, I see this error:
CC [M] fs/nfs/super.o
CC [M] fs/nfs/direct.o
fs/nfs/direct.c:86:29: error: field 'ds_cinfo' has incomplete type
make[2]: *** [fs/nfs/direct.o] Error 1
make[1]: *** [fs/nfs] Error 2
make: *** [fs] Error 2
- Bryan
next prev parent reply other threads:[~2012-04-30 16:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 18:47 [PATCH v3 00/25] directio rewrite Fred Isaman
2012-04-20 18:47 ` [PATCH v3 01/25] NFS: check for req==NULL in nfs_try_to_update_request cleanup Fred Isaman
2012-04-20 18:47 ` [PATCH v3 02/25] NFS: put open context on error in nfs_pagein_multi Fred Isaman
2012-04-20 18:47 ` [PATCH v3 03/25] NFS: put open context on error in nfs_flush_multi Fred Isaman
2012-04-20 18:47 ` [PATCH v3 04/25] NFS: grab open context in direct read Fred Isaman
2012-04-20 18:47 ` [PATCH v3 05/25] NFS4.1: make pnfs_ld_[read|write]_done consistent Fred Isaman
2012-04-20 18:47 ` [PATCH v3 06/25] NFS4.1: Add lseg to struct nfs4_fl_commit_bucket Fred Isaman
2012-04-20 18:47 ` [PATCH v3 07/25] NFS: add a struct nfs_commit_data to replace nfs_write_data in commits Fred Isaman
2012-04-20 18:47 ` [PATCH v3 08/25] NFS: dprintks in directio code were referencing task after put Fred Isaman
2012-04-20 18:47 ` [PATCH v3 09/25] NFS: reverse arg order in nfs_initiate_[read|write] Fred Isaman
2012-04-20 18:47 ` [PATCH v3 10/25] NFS: remove unnecessary casts of void pointers in nfs4filelayout.c Fred Isaman
2012-04-20 18:47 ` [PATCH v3 11/25] NFS: use req_offset where appropriate Fred Isaman
2012-04-20 18:47 ` [PATCH v3 12/25] NFS: create common nfs_pgio_header for both read and write Fred Isaman
2012-04-20 18:47 ` [PATCH v3 13/25] NFS: create struct nfs_page_array Fred Isaman
2012-04-20 18:47 ` [PATCH v3 14/25] NFS: merge _full and _partial read rpc_ops Fred Isaman
2012-04-20 18:47 ` [PATCH v3 15/25] NFS: merge _full and _partial write rpc_ops Fred Isaman
2012-04-20 18:47 ` [PATCH v3 16/25] NFS: create completion structure to pass into page_init functions Fred Isaman
2012-04-20 18:47 ` [PATCH v3 17/25] NFS: remove unused wb_complete field from struct nfs_page Fred Isaman
2012-04-20 18:47 ` [PATCH v3 18/25] NFS: prepare coalesce testing for directio Fred Isaman
2012-04-20 19:46 ` Myklebust, Trond
2012-04-20 20:52 ` Fred Isaman
2012-04-20 21:20 ` Myklebust, Trond
2012-04-20 18:47 ` [PATCH v3 19/25] NFS: rewrite directio read to use async coalesce code Fred Isaman
2012-04-20 18:47 ` [PATCH v3 20/25] NFS: create nfs_generic_commit_list Fred Isaman
2012-04-20 18:47 ` [PATCH v3 21/25] NFS: create struct nfs_commit_info Fred Isaman
2012-04-20 18:47 ` [PATCH v3 22/25] NFS: create nfs_commit_completion_ops Fred Isaman
2012-04-20 18:47 ` [PATCH v3 23/25] NFS: add dreq to nfs_commit_info Fred Isaman
2012-04-20 18:47 ` [PATCH v3 24/25] NFS: avoid some stat gathering for direct io Fred Isaman
2012-04-20 18:47 ` [PATCH v3 25/25] NFS: rewrite directio write to use async coalesce code Fred Isaman
2012-04-30 16:10 ` Bryan Schumaker [this message]
2012-04-30 16:58 ` Bryan Schumaker
2012-04-20 20:00 ` [PATCH v3 00/25] directio rewrite Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9EB992.9040501@netapp.com \
--to=bjschuma@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.