From: Paolo Bonzini <pbonzini@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Hu Tao <hutao@cn.fujitsu.com>
Subject: Re: [PATCH for 3.4] virtio-scsi: fix TMF use-after-free
Date: Tue, 01 May 2012 10:09:54 +0200 [thread overview]
Message-ID: <4F9F9A52.8010100@redhat.com> (raw)
In-Reply-To: <1334758148.4410.51.camel@dabdike>
Il 18/04/2012 16:09, James Bottomley ha scritto:
>> > Fix a race in TMF path, where cmd may have been already freed
>> > by virtscsi_complete_free after waking up from the completion.
> There's no may about this; the command will be freed long before the
> completion waiter is awoken. The description could be clearer.
>
> The problem is a use after free in virtscsi_tmf because the
> virtio_scsi_command is freed before the completion returns.
>
> The fix is to make callers specifying a completion responsible for
> freeing the command in all cases.
I don't see this in the pull request, were you waiting for v2 with a
better commit message?
Paolo
next prev parent reply other threads:[~2012-05-01 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 13:46 [PATCH for 3.4] virtio-scsi: fix TMF use-after-free Paolo Bonzini
2012-04-18 14:01 ` Zhi Yong Wu
2012-04-18 14:09 ` James Bottomley
2012-05-01 8:09 ` Paolo Bonzini [this message]
2012-05-01 8:52 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9F9A52.8010100@redhat.com \
--to=pbonzini@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hutao@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.