From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 07/26] drm/radeon: add proper locking to the SA v2 Date: Tue, 01 May 2012 14:31:20 +0200 Message-ID: <4F9FD798.7090703@vodafone.de> References: <1335797464-14317-1-git-send-email-deathsimple@vodafone.de> <1335797464-14317-8-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 79F3F9E7F7 for ; Tue, 1 May 2012 05:31:23 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 30.04.2012 17:58, Jerome Glisse wrote: > On Mon, Apr 30, 2012 at 10:50 AM, Christian K=F6nig > wrote: >> Make the suballocator self containing to locking. >> >> v2: split the bugfix into a seperate patch. >> >> Signed-off-by: Christian K=F6nig > I would say NAK but i don't have better solution yet to the issue. > Idea is that cs mutex protect the SA, i am trying hard to avoid adding > new lock, in fact i would like to remove more lock and have some idea > for that. I looked at the whole patch set and the issue is with radeon > semaphore allocation in ttm move blit case, all other case have the cs > mutex taken already. So if no better solution than yeah introduce a > new lock. Well, my idea was to remove the cs mutex in the long term. But just = reading your other mail, I think I better describe the picture as a = whole there. Just let me mention that I intended to be this the lock for the = "transaction memory allocator", so it pretty much matches your idea also. Christian.