From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SPD0d-0007zH-Kz for mharc-grub-devel@gnu.org; Tue, 01 May 2012 09:20:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPD0b-0007zB-LV for grub-devel@gnu.org; Tue, 01 May 2012 09:20:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPD0Z-0004RE-DG for grub-devel@gnu.org; Tue, 01 May 2012 09:20:49 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:46366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPD0Y-0004Qx-Ul for grub-devel@gnu.org; Tue, 01 May 2012 09:20:47 -0400 Received: by werj55 with SMTP id j55so3178060wer.0 for ; Tue, 01 May 2012 06:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=XZ3fVa3zXA/5sxitzUPCfF9BT75X6WF72t+BiYDVTwk=; b=gx3i73CpdzjyKiDaRfBTSO/33VfUsvb4SbZE1ybL1WInC0y10mBS015S0EN7plouHE 59Deool4xCrf8HB4BPZm15erTCYZ/7d9K9mfJsHSzvORTtOciYDtB1FD4ZfOfbVOsKGN 854N0I0S7+HhrD29Pb0xKEiEdjfwbJEPO5fgdrjcBMv8mSrcgxvu7RNnqY8UEtS2Ykhg twFDnkN1CTjHG5UYd00ikTL8R6Swwx7+07uEW7XwqV7WqPCFPNp5sYeOZphor412uEWK DaA5QmKHTgHtXUzNX8x9gMvT2PFp7Yt+BkvH5hodzUMO5JZ8gUxt7fx34aD85sTnfKY8 q91A== Received: by 10.180.77.4 with SMTP id o4mr5231748wiw.17.1335878444956; Tue, 01 May 2012 06:20:44 -0700 (PDT) Received: from debian.x201.phnet (dhcp-wlan-eduroam-192-41-134-151.uzh.ch. [192.41.134.151]) by mx.google.com with ESMTPS id fn2sm57640986wib.0.2012.05.01.06.20.42 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 May 2012 06:20:43 -0700 (PDT) Message-ID: <4F9FE32A.7080203@gmail.com> Date: Tue, 01 May 2012 15:20:42 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] bug fix for bootp References: <4F9D6D77.6090604@gmail.com> <4F9D8A01.2060809@gmail.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig424D29D66E2173284F3A10ED" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2012 13:20:51 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig424D29D66E2173284F3A10ED Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.04.2012 20:59, Bean wrote: > 2012/4/30 Bean : >> 2012/4/30 Vladimir '=CF=86-coder/phcoder' Serbinenko : >>> On 29.04.2012 20:26, Bean wrote: >>>> Hi, >>>> >>>> It should be ok, since it's inside FOR_NET_NETWORK_LEVEL_INTERFAC= ES >>>> (inf) loop and compare inf->hwaddress.mac to the current dhcp respon= se >>>> packet. >>> It's not. You return even if packet didn't match. >> Hi, >> >> Oh i see, i forget about the return a few lines beyond. > Hi, > > oh, there seems to be a missing grub_netbuff_free here as well, pls > check if this is ok. The patch is still incorrect. Namely the problem is with netbuff_pull being called in every loop. I've committed a fixed version. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig424D29D66E2173284F3A10ED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+f4yoACgkQNak7dOguQgm2NAD/QbGFbcg4cUSJieMSIdW4bY8O jCl+BGrkrrbQF2JVW/QBAJtbnDKWxZchMkMmHlPudiBvFAzeB6uS7XeDukiEvPLS =Kuku -----END PGP SIGNATURE----- --------------enig424D29D66E2173284F3A10ED--