From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface
Date: Tue, 01 May 2012 16:00:59 +0200 [thread overview]
Message-ID: <4F9FEC9B.3010603@redhat.com> (raw)
In-Reply-To: <1335851588-21011-1-git-send-email-sw@weilnetz.de>
Il 01/05/2012 07:53, Stefan Weil ha scritto:
> If neither width nor height changes, nothing has to be done.
>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This patch improves SDL for any host (for example with remote X displays),
> but the main reason why I wrote it was another problem:
>
> On w32 / w64 hosts, qemu-system-arm has a deadlock when it calls
> sdl_resize_displaysurface during Linux boot. One thread waits for
> a critical region, another thread waits inside SDL_SetVideoMode.
>
> The patch avoids this problem. Paolo, maybe you have an idea what
> could cause the deadlock.
No idea---honestly, my w32 interest is limited to replacing hacks with
proper solutions. :) It turns out that in many cases you can fix bugs
along the way and that helps having people look at your patches...
Paolo
next prev parent reply other threads:[~2012-05-01 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 5:53 [Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface Stefan Weil
2012-05-01 14:00 ` Paolo Bonzini [this message]
2012-05-04 19:49 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9FEC9B.3010603@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.