From: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>,
peff@peff.net, pclouds@gmail.com, j.sixt@viscovery.net
Subject: Re: [PATCH resend] diff --stat: use less columns for change counts
Date: Tue, 01 May 2012 17:24:49 +0200 [thread overview]
Message-ID: <4FA00041.3070909@in.waw.pl> (raw)
In-Reply-To: <7vobq8as95.fsf@alter.siamese.dyndns.org>
On 05/01/2012 04:30 PM, Junio C Hamano wrote:
> Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
>
>> This resend applies and tests cleanly against both current next and pu.
>
> Thanks; will queue.
>
>> old diff-stat:
>> Documentation/gitcore-tutorial.txt | 4 +-
>> diff.c | 48 ++++++++++++++++----
>> t/t0023-crlf-am.sh | 2 +-
>> t/t1200-tutorial.sh | 4 +-
>> t/t3404-rebase-interactive.sh | 2 +-
>> t/t3903-stash.sh | 2 +-
>> t/t4012-diff-binary.sh | 19 ++++++++
>> ...
>>
>> new diff-stat:
>> Documentation/gitcore-tutorial.txt | 4 +-
>> diff.c | 48 +++++++++++++++++-----
>> t/t0023-crlf-am.sh | 2 +-
>> t/t1200-tutorial.sh | 4 +-
>> t/t3404-rebase-interactive.sh | 2 +-
>> t/t3903-stash.sh | 2 +-
>> t/t4012-diff-binary.sh | 19 +++++++++
>
> Having said that, given the above miniscule differences, I am not really
> sure if it is worth 2300+ lines worth of code churn, though.
Yeah, I understand that. So I leave it to your decision.
Thanks,
Zbyszek
prev parent reply other threads:[~2012-05-01 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 20:38 [PATCH resend] diff --stat: use less columns for change counts Zbigniew Jędrzejewski-Szmek
2012-05-01 14:30 ` Junio C Hamano
2012-05-01 15:24 ` Zbigniew Jędrzejewski-Szmek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA00041.3070909@in.waw.pl \
--to=zbyszek@in.waw.pl \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.