Re: [PATCH/RFC v3 14/14] vivi: Add controls

[Sylwester Nawrocki <snjw23@gmail.com>]

On 05/01/2012 07:48 PM, Hans Verkuil wrote:
> On Tue May 1 2012 19:40:55 Sylwester Nawrocki wrote:
>> On 04/30/2012 06:09 PM, Hans Verkuil wrote:
>>> On Friday 27 April 2012 16:23:31 Sylwester Nawrocki wrote:
...
>>> Why add these controls to vivi? It doesn't belong here.
>>
>> Yeah, my intention was to provide some basic means for validating the
>> new controls, especially integer menu ones. I really don't use vivi
>> for testing, but I think not many people have currently access to the
>> hardware I work with. So this is just in case Mauro wants to do tests
>> of the core control framework changes. I agree this patch doesn't
>> make sense for anything other than that.
>>
>> I have also a small patch for v4l2-ctl to support integer menu
>> control enumeration. However I run into some weird problems when
>> I cross compiled it for ARM (individual menu names are not listed)
>> and didn't get around to fix that yet. So I didn't yet send that
>> v4l2-ctl patch out.
> 
> There is already an int-menu control in vivi, and v4l2-ctl already
> support integer menus as well (as does qv4l2 and v4l2-compliance).
> 
> So this should be all ready for you.

Oh, it is there already! Must have been too busy to notice that :/

> BTW, it would be nice to get g/s_selection support in v4l2-ctl, that is
> still missing. And a good test in v4l2-compliance would be great as well.

Yeah, I noticed that too recently, we use selections on video nodes 
in some drivers and media-ctl can be only used for subdevs. I'll try
to find some time to add selection ioctls support to v4l2-ctl first,
perhaps this weekend.

> Have you run v4l2-compliance lately? It's getting pretty good at 
> catching all sorts of inconsistencies.

No, I haven't used it for a while. I know from the last run I need to
add G/S_PRIORITY support in one of the drivers. :)

I'm going to give it a try, however I'm going to need to deal with 
more and more media controller nodes. For example the fimc-lite
camera host driver I posted recently can be used with media controller
API only, I set only V4L2_CAP_STREAMING at the video node, as it was 
agreed previously. I assume some support for media controller API 
needs to be added to v4l2-compliance as well ?

--

Regards,
Sylwester