From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] tune-sh4.inc: Fix spelling of big-endian feature set
Date: Tue, 01 May 2012 11:34:16 -0700 [thread overview]
Message-ID: <4FA02CA8.1090501@linux.intel.com> (raw)
In-Reply-To: <8fd6ef92079e16fdf31fe8b6f3194df7a858ed71.1335569869.git.peter.seebach@windriver.com>
On 04/27/2012 04:51 PM, Peter Seebach wrote:
> In tune-sh3, tune-xscale, and tune-sh4, several FEATURES lines referred
> to nonexistent features like "sh3eb" when they should have referred to "sh3
> bigendian" or the like. Caught by the TUNEVALID sanity check.
>
> Signed-off-by: Peter Seebach<peter.seebach@windriver.com>
> ---
> meta/conf/machine/include/tune-sh3.inc | 2 +-
> meta/conf/machine/include/tune-sh4.inc | 4 ++--
> meta/conf/machine/include/tune-xscale.inc | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-sh3.inc b/meta/conf/machine/include/tune-sh3.inc
> index 816c9c4..70bb10b 100644
> --- a/meta/conf/machine/include/tune-sh3.inc
> +++ b/meta/conf/machine/include/tune-sh3.inc
> @@ -11,7 +11,7 @@ TUNE_ARCH_tune-sh3 = "sh3"
> TUNE_PKGARCH_tune-sh3 = "sh3"
> PACKAGE_EXTRA_ARCHS_tune-sh3 = "sh sh3"
>
> -TUNE_FEATURES_tune-sh3eb = "sh3eb"
> +TUNE_FEATURES_tune-sh3eb = "sh3 bigendian"
> TUNE_ARCH_tune-sh3eb = "sh3eb"
> TUNE_PKGARCH_tune-sh3eb = "sh3eb"
> PACKAGE_EXTRA_ARCHS_tune-sh3eb = "sheb sh3eb"
> diff --git a/meta/conf/machine/include/tune-sh4.inc b/meta/conf/machine/include/tune-sh4.inc
> index f971f23..00cfc3d 100644
> --- a/meta/conf/machine/include/tune-sh4.inc
> +++ b/meta/conf/machine/include/tune-sh4.inc
> @@ -18,7 +18,7 @@ TUNE_ARCH_tune-sh4 = "sh4"
> TUNE_PKGARCH_tune-sh4 = "sh4"
> PACKAGE_EXTRA_ARCHS_tune-sh4 = "sh sh4"
>
> -TUNE_FEATURES_tune-sh4eb = "sh4eb"
> +TUNE_FEATURES_tune-sh4eb = "sh4 bigendian"
> TUNE_ARCH_tune-sh4eb = "sh4eb"
> TUNE_PKGARCH_tune-sh4eb = "sh4eb"
> PACKAGE_EXTRA_ARCHS_tune-sh4eb = "sheb sh4eb"
> @@ -28,7 +28,7 @@ TUNE_ARCH_tune-sh4a = "sh4"
> TUNE_PKGARCH_tune-sh4a = "sh4a"
> PACKAGE_EXTRA_ARCHS_tune-sh4a = "sh sh4 sh4a"
>
> -TUNE_FEATURES_tune-sh4aeb = "sh4aeb"
> +TUNE_FEATURES_tune-sh4aeb = "sh4a bigendian"
> TUNE_ARCH_tune-sh4aeb = "sh4eb"
> TUNE_PKGARCH_tune-sh4aeb = "sh4aeb"
> PACKAGE_EXTRA_ARCHS_tune-sh4aeb = "sheb sh4eb sh4aeb"
> diff --git a/meta/conf/machine/include/tune-xscale.inc b/meta/conf/machine/include/tune-xscale.inc
> index 54f3727..80a3683 100644
> --- a/meta/conf/machine/include/tune-xscale.inc
> +++ b/meta/conf/machine/include/tune-xscale.inc
> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-xscale = "${TUNE_FEATURES_tune-armv5te} xscale"
> PACKAGE_EXTRA_ARCHS_tune-xscale = "${PACKAGE_EXTRA_ARCHS_tune-armv5te}"
>
> AVAILTUNES += "xscale-be"
> -TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale-be"
> +TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale bigendian"
> PACKAGE_EXTRA_ARCHS_tune-xscale-be = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb}"
>
> # webkit-gtk has alignment issues with double instructions on armv5 so
Merged this patch into OE-Core
Thanks
Sau!
next prev parent reply other threads:[~2012-05-01 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 23:51 [PATCH 0/2] sanity.bbclass: Toolchain sanity checks Peter Seebach
2012-04-27 23:51 ` [PATCH 1/2] tune-sh4.inc: Fix spelling of big-endian feature set Peter Seebach
2012-05-01 18:34 ` Saul Wold [this message]
2012-04-27 23:51 ` [PATCH 2/2] sanity.bbclass: Implement initial toolchain sanity checks Peter Seebach
-- strict thread matches above, loose matches on Subject: below --
2012-04-30 20:33 [v3] [PATCH 0/2] toolchain sanity checks, revised Peter Seebach
2012-04-30 20:33 ` [PATCH 1/2] tune-sh4.inc: Fix spelling of big-endian feature set Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA02CA8.1090501@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.