All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] mounts.nfs: v2 and v3 background mounts should retry when server is down.
Date: Tue, 01 May 2012 15:35:45 -0400	[thread overview]
Message-ID: <4FA03B11.1020302@RedHat.com> (raw)
In-Reply-To: <1335368390-26767-1-git-send-email-steved@redhat.com>



On 04/25/2012 11:39 AM, Steve Dickson wrote:
> The point of background mounts is to have the mount
> retried if the mount fails. This patch allows the v2/v3
> background mount to proceed in the case when the server
> is down by not making EOPNOTSUPP a permanent error.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.

> ---
>  utils/mount/stropts.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index d52e21a..e09aa7c 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -911,7 +911,8 @@ static int nfsmount_parent(struct nfsmount_info *mi)
>  	if (nfs_try_mount(mi))
>  		return EX_SUCCESS;
>  
> -	if (nfs_is_permanent_error(errno)) {
> +	/* retry background mounts when the server is not up */
> +	if (nfs_is_permanent_error(errno) && errno != EOPNOTSUPP) {
>  		mount_error(mi->spec, mi->node, errno);
>  		return EX_FAIL;
>  	}
> @@ -946,7 +947,8 @@ static int nfsmount_child(struct nfsmount_info *mi)
>  		if (nfs_try_mount(mi))
>  			return EX_SUCCESS;
>  
> -		if (nfs_is_permanent_error(errno))
> +		/* retry background mounts when the server is not up */
> +		if (nfs_is_permanent_error(errno) && errno != EOPNOTSUPP)
>  			break;
>  
>  		if (time(NULL) > timeout)
> -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> 

      parent reply	other threads:[~2012-05-01 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 15:39 [PATCH 1/1] mounts.nfs: v2 and v3 background mounts should retry when server is down Steve Dickson
2012-04-25 20:31 ` Chuck Lever
2012-04-26 17:36   ` Steve Dickson
2012-05-01 19:35 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA03B11.1020302@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.