From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: [PATCH] libata-eh don't waste time retrying media errors (v2) Date: Tue, 01 May 2012 23:03:19 -0400 Message-ID: <4FA0A3F7.7000401@teksavvy.com> References: <4FA043BE.2010009@teksavvy.com> <4FA04714.7050602@teksavvy.com> <20120501215854.GA21677@google.com> <4FA07655.6090506@teksavvy.com> <4FA07932.2090003@teksavvy.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030700090404080904050900" Return-path: Received: from ironport-out.teksavvy.com ([206.248.143.162]:63409 "EHLO ironport-out.teksavvy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758177Ab2EBDDV (ORCPT ); Tue, 1 May 2012 23:03:21 -0400 In-Reply-To: <4FA07932.2090003@teksavvy.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: IDE/ATA development list This is a multi-part message in MIME format. --------------030700090404080904050900 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ATA and SATA drives have had built-in retries for media errors for as long as they've been commonplace in computers (early 1990s). When libata stumbles across a bad sector, it can waste minutes sitting there doing retry after retry before finally giving up and letting the higher layers deal with it. This patch removes retries for media errors only. Signed-off-by: Mark Lord --- version 2; the original patch changed more than intended. --- linux/drivers/ata/libata-eh.c.orig 2012-04-27 13:17:35.000000000 -0400 +++ linux/drivers/ata/libata-eh.c 2012-05-01 22:40:00.182425015 -0400 @@ -2122,7 +2122,8 @@ if (qc->flags & ATA_QCFLAG_IO || (!(qc->err_mask & AC_ERR_INVALID) && qc->err_mask != AC_ERR_DEV)) - qc->flags |= ATA_QCFLAG_RETRY; + if (!(qc->err_mask & AC_ERR_MEDIA)) + qc->flags |= ATA_QCFLAG_RETRY; /* accumulate error info */ ehc->i.dev = qc->dev; --------------030700090404080904050900 Content-Type: text/x-patch; name="02_libata_sata_dont_retry_media_errors.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="02_libata_sata_dont_retry_media_errors.patch" --- linux/drivers/ata/libata-eh.c.orig 2012-04-27 13:17:35.000000000 -0400 +++ linux/drivers/ata/libata-eh.c 2012-05-01 22:40:00.182425015 -0400 @@ -2122,7 +2122,8 @@ if (qc->flags & ATA_QCFLAG_IO || (!(qc->err_mask & AC_ERR_INVALID) && qc->err_mask != AC_ERR_DEV)) - qc->flags |= ATA_QCFLAG_RETRY; + if (!(qc->err_mask & AC_ERR_MEDIA)) + qc->flags |= ATA_QCFLAG_RETRY; /* accumulate error info */ ehc->i.dev = qc->dev; --------------030700090404080904050900--