All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state
Date: Wed, 02 May 2012 09:08:55 +0200	[thread overview]
Message-ID: <4FA0DD87.6080302@redhat.com> (raw)
In-Reply-To: <1335559216-13849-3-git-send-email-lcapitulino@redhat.com>

> diff --git a/input.c b/input.c
> index 6b5c2c3..47e6900 100644
> --- a/input.c
> +++ b/input.c
> @@ -130,7 +130,7 @@ void qemu_remove_led_event_handler(QEMUPutLEDEntry *entry)
>  
>  void kbd_put_keycode(int keycode)
>  {
> -    if (!runstate_is_running()) {
> +    if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) {
>          return;
>      }
>      if (qemu_put_kbd_event) {

IIRC there is a simliar check for the mouse ...

Does it make sense to add a runstate_is_running_or_suspended() function?

Overall the series looks good to me.

cheers,
  Gerd

       reply	other threads:[~2012-05-02  7:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1335559216-13849-1-git-send-email-lcapitulino@redhat.com>
     [not found] ` <1335559216-13849-3-git-send-email-lcapitulino@redhat.com>
2012-05-02  7:08   ` Gerd Hoffmann [this message]
2012-05-02 18:34     ` [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state Luiz Capitulino
2012-05-03  7:56       ` Gerd Hoffmann
2012-05-03 20:30         ` Luiz Capitulino
2012-05-04  8:50           ` Gerd Hoffmann
2012-05-04 13:33             ` Luiz Capitulino
2012-05-04 13:54               ` Gerd Hoffmann
2012-05-04 14:00                 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA0DD87.6080302@redhat.com \
    --to=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.