Re: [Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro

["Andreas Färber" <andreas.faerber@web.de>]

Am 02.05.2012 10:02, schrieb Kevin Wolf:
> Am 01.05.2012 00:15, schrieb Andreas Färber:
>> From: Pavel Borzenkov <pavel.borzenkov@gmail.com>
>>
>> Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac
>> OS X host. The patch is based on Ben Leslie's patch:
>> http://patchwork.ozlabs.org/patch/97859/
>>
>> Signed-off-by: Ben Leslie <benno@benno.id.au>
>> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>> ---
>>  block/raw-posix.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/block/raw-posix.c b/block/raw-posix.c
>> index 2d1bc13..03fcfcc 100644
>> --- a/block/raw-posix.c
>> +++ b/block/raw-posix.c
>> @@ -29,7 +29,7 @@
>>  #include "module.h"
>>  #include "block/raw-posix-aio.h"
>>  
>> -#ifdef CONFIG_COCOA
>> +#if defined(__APPLE__) && (__MACH__)
> 
> Is there a 'defined' missing?

Seems like it, I'll send you a fixup patch.

Thanks for noticing,

Andreas