From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH 00/11] m68knommu: remove ColdFire sub-architecture directories
Date: Wed, 2 May 2012 19:47:19 +1000 [thread overview]
Message-ID: <4FA102A7.409@snapgear.com> (raw)
In-Reply-To: <CAMuHMdWzjtD2C+AjxAi3v3B=aaMPX_RwNHpQZUt1U8jX6uC1cQ@mail.gmail.com>
Hi Geert,
On 05/02/2012 07:16 PM, Geert Uytterhoeven wrote:
> On Wed, May 2, 2012 at 3:08 AM,<gerg@snapgear.com> wrote:
>> Move all the ColdFire sub-architecture code into the platform/coldfire
>> directory, and remove the sub-architecture directories. We already build
>> the common ColdFire components based on sub-architecture type anyway,
>> so there is very little Makefile change required.
>
> This looks like a weird diffstat:
>
>> arch/m68k/Makefile | 10 ----------
>> arch/m68k/platform/5206/Makefile | 18 ------------------
>> arch/m68k/platform/520x/Makefile | 17 -----------------
>> arch/m68k/platform/523x/Makefile | 17 -----------------
>> arch/m68k/platform/5249/Makefile | 18 ------------------
>> arch/m68k/platform/5272/Makefile | 18 ------------------
>> arch/m68k/platform/527x/Makefile | 18 ------------------
>> arch/m68k/platform/528x/Makefile | 18 ------------------
>> arch/m68k/platform/5307/Makefile | 20 --------------------
>> arch/m68k/platform/532x/Makefile | 18 ------------------
>> arch/m68k/platform/5407/Makefile | 18 ------------------
>> arch/m68k/platform/54xx/Makefile | 19 -------------------
>> arch/m68k/platform/coldfire/Makefile | 24 ++++++++++++++----------
>> b/arch/m68k/Makefile | 2 --
>> b/arch/m68k/platform/coldfire/Makefile | 4 ++--
>
> We already had these two files in the diffstat, with different values?
>
>> b/arch/m68k/platform/coldfire/m5206.c | 1 -
>> b/arch/m68k/platform/coldfire/m520x.c | 1 -
>> b/arch/m68k/platform/coldfire/m523x.c | 1 -
>> b/arch/m68k/platform/coldfire/m5249.c | 1 -
>> b/arch/m68k/platform/coldfire/m5272.c | 1 -
>> b/arch/m68k/platform/coldfire/m527x.c | 1 -
>> b/arch/m68k/platform/coldfire/m528x.c | 1 -
>> b/arch/m68k/platform/coldfire/m532x.c | 1 -
>> b/arch/m68k/platform/coldfire/m5407.c | 1 -
>> b/arch/m68k/platform/coldfire/m54xx.c | 1 -
>> b/arch/m68k/platform/coldfire/nettel.c | 1 -
>
> All of these are created, not deleted?
Yeah, it is pretty odd. I think diffstat is getting confused by the
git rename/delete actions in the diffs. I used git format-patch with
the -M option, since there was so much moving about of files.
> The actual patches look fine, though ;-)
Thanks for the review :-)
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-05-02 9:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 1:08 [PATCH 00/11] m68knommu: remove ColdFire sub-architecture directories gerg
2012-05-02 1:08 ` [PATCH 01/11] m68knommu: move the 5206 platform code into the common ColdFire code directory gerg
2012-05-02 1:08 ` [PATCH 02/11] m68knommu: move the 520x " gerg
2012-05-02 1:08 ` [PATCH 03/11] m68knommu: move the 523x " gerg
2012-05-02 1:08 ` [PATCH 04/11] m68knommu: move the 5249 " gerg
2012-05-02 1:09 ` [PATCH 05/11] m68knommu: move the 5272 " gerg
2012-05-02 1:09 ` [PATCH 06/11] m68knommu: move the 527x " gerg
2012-05-02 1:09 ` [PATCH 07/11] m68knommu: move the 528x " gerg
2012-05-02 1:09 ` [PATCH 08/11] m68knommu: move the 5307 " gerg
2012-05-02 1:09 ` [PATCH 09/11] m68knommu: move the 5407 " gerg
2012-05-02 1:09 ` [PATCH 10/11] m68knommu: move the 532x " gerg
2012-05-02 1:09 ` [PATCH 11/11] m68knommu: move the 54xx " gerg
2012-05-02 9:16 ` [PATCH 00/11] m68knommu: remove ColdFire sub-architecture directories Geert Uytterhoeven
2012-05-02 9:47 ` Greg Ungerer [this message]
2012-05-02 9:50 ` Luis Alves
2012-05-02 14:07 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA102A7.409@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.