From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPZnk-0007Xn-N7 for qemu-devel@nongnu.org; Wed, 02 May 2012 09:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPZne-0003J5-FZ for qemu-devel@nongnu.org; Wed, 02 May 2012 09:41:04 -0400 Received: from mout.web.de ([212.227.15.3]:58450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPZne-0003Ip-5y for qemu-devel@nongnu.org; Wed, 02 May 2012 09:40:58 -0400 Message-ID: <4FA13965.4070906@web.de> Date: Wed, 02 May 2012 15:40:53 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , Paolo Bonzini , Lee Essen , qemu-devel@nongnu.org Am 02.05.2012 15:24, schrieb Paolo Bonzini: >> But that would leave Illumos broken. For the record, reverting would leave whatever Paolo was fixing broken but would restore Illumos. > I'd rather apply this one. > > Please do. The right solution for 1.2 is to understand the places in which > slirp cannot use netinet/tcp.h constants (the MSS for example), and > otherwise use that header. Jan, should I prepare a mechanical prefix addition as suggested by Blue? Should we apply this ugly-but-least-intrusive build fix? Or do you have any other preference or idea? Andreas