From: Jan Kiszka <jan.kiszka@web.de>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Lee Essen <lee.essen@nowonline.co.uk>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*
Date: Wed, 02 May 2012 10:48:59 -0300 [thread overview]
Message-ID: <4FA13B4B.5000902@web.de> (raw)
In-Reply-To: <4FA13965.4070906@web.de>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 2012-05-02 10:40, Andreas Färber wrote:
> Am 02.05.2012 15:24, schrieb Paolo Bonzini:
>>> But that would leave Illumos broken.
>
> For the record, reverting would leave whatever Paolo was fixing broken
> but would restore Illumos.
>
>> I'd rather apply this one.
>>
>> Please do. The right solution for 1.2 is to understand the places in which
>> slirp cannot use netinet/tcp.h constants (the MSS for example), and
>> otherwise use that header.
>
> Jan, should I prepare a mechanical prefix addition as suggested by Blue?
> Should we apply this ugly-but-least-intrusive build fix? Or do you have
> any other preference or idea?
I'm fine with a minimal fix like you suggested. The renaming should
probably be applied to a broader scope. So it's an exercise to be done
systematically and without any hurry.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2012-05-02 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAu8pHty6LknkHcQseB29X4qQxguezAShsC5aGzMYHO1WRpJwg@mail.gmail.com>
2012-05-02 13:24 ` [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* Paolo Bonzini
2012-05-02 13:40 ` Andreas Färber
2012-05-02 13:48 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA13B4B.5000902@web.de \
--to=jan.kiszka@web.de \
--cc=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=lee.essen@nowonline.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.