From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] create_ref_entry(): move check_refname_format() call to callers
Date: Wed, 02 May 2012 17:38:04 +0200 [thread overview]
Message-ID: <4FA154DC.1060607@alum.mit.edu> (raw)
In-Reply-To: <7vsjfkexh1.fsf@alter.siamese.dyndns.org>
On 04/30/2012 11:11 PM, Junio C Hamano wrote:
> Michael Haggerty<mhagger@alum.mit.edu> writes:
>
>> For example, have all of the following code paths been audited to make
>> sure that they cannot introduce class (3) refnames into a repository
>> (including via symbolic refs with class (3) targets) even in the face
>> of a malicious remote? Can we (and do we want to) rely on this level
>> of vigilance being sustained in the future?
>
> Auditing is one thing, but perhaps the right solution to that issue is to
> refactor the existing code so that we have only a handful (preferrably
> one) API entry point that is used to create a new ref (not to be confused
> with create_ref_entry(), which is not necessarily about creating a ref)?
Yes, definitely. And more broadly, I want refs.{c,h} to become the
*only* mechanism for working with refs.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2012-05-02 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 6:18 [PATCH] create_ref_entry(): move check_refname_format() call to callers mhagger
2012-04-29 11:58 ` Jeff King
2012-04-30 6:15 ` Junio C Hamano
2012-04-30 16:18 ` Michael Haggerty
2012-04-30 17:14 ` Junio C Hamano
2012-04-30 20:29 ` Michael Haggerty
2012-04-30 21:11 ` Junio C Hamano
2012-05-02 15:38 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA154DC.1060607@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.