All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Josh Durgin <josh.durgin@dreamhost.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rbd: add discard support
Date: Wed, 02 May 2012 18:42:24 +0200	[thread overview]
Message-ID: <4FA163F0.6090307@redhat.com> (raw)
In-Reply-To: <CAJSP0QUaoQ8qBwNWYSovgFjmphE-sjqcOCi5um+8wK42ZGiptA@mail.gmail.com>

Am 01.05.2012 10:39, schrieb Stefan Hajnoczi:
> On Tue, May 1, 2012 at 7:16 AM, Josh Durgin <josh.durgin@dreamhost.com> wrote:
>> Change the write flag to an operation type in RBDAIOCB, and make the
>> buffer optional since discard doesn't use it.
>>
>> Discard is first included in librbd 0.1.2 (which is in Ceph 0.46).
>> If librbd is too old, leave out qemu_rbd_aio_discard entirely,
>> so the old behavior is preserved.
>>
>> Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
>> ---
>>  block/rbd.c |   89 ++++++++++++++++++++++++++++++++++++++++++++++++----------
>>  1 files changed, 73 insertions(+), 16 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2012-05-02 16:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-01  6:16 [Qemu-devel] [PATCH] rbd: add discard support Josh Durgin
2012-05-01  8:39 ` Stefan Hajnoczi
2012-05-02 16:42   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA163F0.6090307@redhat.com \
    --to=kwolf@redhat.com \
    --cc=josh.durgin@dreamhost.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.