All of lore.kernel.org
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Ulrich Drepper <drepper@akkadia.org>
Cc: akpm@linux-foundation.org, dyoung@redhat.com,
	fengguang.wu@intel.com, kosaki.motohiro@jp.fujitsu.com,
	linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com,
	kosaki.motohiro@gmail.com
Subject: Re: [PATCH] Cleanup page-type.c
Date: Wed, 02 May 2012 14:19:01 -0400	[thread overview]
Message-ID: <4FA17A95.9050603@gmail.com> (raw)
In-Reply-To: <201205021441.q42Ef1ap026902@drepperk.user.openhosting.com>

(5/2/12 10:41 AM), Ulrich Drepper wrote:
> Compiling page-type.c with a recent compiler produces many warnings,
> mostly related to signed/unsigned comparisons.  This patch cleans up
> most of them.
> 
> One remaining warning is about an unused parameter.  The<compiler.h>
> file doesn't define a __unused macro (or the like) yet.  This can be
> addressed later.
> 
> The line numbers for this patch correspond to the file changed to remove
> the duplicate definitions of the KPF_* macros which is contained in
> another patch.  It should apply cleanly albeit with warnings even without
> that patch applied first.
> 
> 
> Signed-off-by: Ulrich Drepper<drepper@gmail.com>
> 
>   page-types.c |   22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)

Looks good to me.
 Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


offtopic:
Wu, I have (unrelated) one question. page-type is used from production
systems nowadays. Why don't you want to move page-type.c into tools/ dir?


  reply	other threads:[~2012-05-02 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 14:41 [PATCH] Cleanup page-type.c Ulrich Drepper
2012-05-02 18:19 ` KOSAKI Motohiro [this message]
2012-05-02 23:06   ` Fengguang Wu
2012-05-03  1:41     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA17A95.9050603@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@akkadia.org \
    --cc=dyoung@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.