From: Breno Leitao <brenohl@br.ibm.com>
To: Thadeu Lima De Souza Cascardo <thadeul@br.ibm.com>
Cc: Jeff Mahoney <jeffm@suse.com>,
Breno Leitao <leitao@linux.vnet.ibm.com>,
Network Development <netdev@vger.kernel.org>,
Olaf Hering <ohering@suse.com>
Subject: Re: [PATCH] ehea: add alias entry for portN properties
Date: Wed, 02 May 2012 15:34:12 -0300 [thread overview]
Message-ID: <4FA17E24.3020306@br.ibm.com> (raw)
In-Reply-To: <4FA17C4E.1030905@suse.com>
Thadeu,
Could you check this patch, please?
Thanks
On 05/02/2012 03:26 PM, Jeff Mahoney wrote:
> Use separate table for alias entries in the ehea module,
> otherwise the probe() function will operate on the separate ports
> instead of the lhea-"root" entry of the device-tree
>
> Initially reported here:
> https://bugzilla.novell.com/show_bug.cgi?id=435215
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Olaf Hering <ohering@suse.com>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -103,6 +103,19 @@ static int __devinit ehea_probe_adapter(
>
> static int __devexit ehea_remove(struct platform_device *dev);
>
> +static struct of_device_id ehea_module_device_table[] = {
> + {
> + .name = "lhea",
> + .compatible = "IBM,lhea",
> + },
> + {
> + .type = "network",
> + .compatible = "IBM,lhea-ethernet",
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, ehea_module_device_table);
> +
> static struct of_device_id ehea_device_table[] = {
> {
> .name = "lhea",
> @@ -110,7 +123,6 @@ static struct of_device_id ehea_device_t
> },
> {},
> };
> -MODULE_DEVICE_TABLE(of, ehea_device_table);
>
> static struct of_platform_driver ehea_driver = {
> .driver = {
prev parent reply other threads:[~2012-05-02 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 18:26 [PATCH] ehea: add alias entry for portN properties Jeff Mahoney
2012-05-02 18:34 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA17E24.3020306@br.ibm.com \
--to=brenohl@br.ibm.com \
--cc=jeffm@suse.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ohering@suse.com \
--cc=thadeul@br.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.