Re: [PATCH 2/4] rt-tests: cyclictest segfault with '-a'

[Darren Hart <dvhart@linux.intel.com>]

On 05/01/2012 07:44 PM, Frank Rowand wrote:
> This fixes a segfault on ARM when the '-a' option is used.
> 
> man sched_setaffinity says to use pthread_setaffinity_np() when using the
> POSIX threads API.
> 
> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>

Compile tested and tried "-a 0", but my ARM kernel/emulation is UP, so
not sure this is of much value.

Tested-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  src/cyclictest/cyclictest.c |    4 	3 +	1 -	0 !
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: b/src/cyclictest/cyclictest.c
> ===================================================================
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -612,6 +612,7 @@ void *timerthread(void *param)
>  	struct thread_stat *stat = par->stats;
>  	int stopped = 0;
>  	cpu_set_t mask;
> +	pthread_t thread;
>  
>  	/* if we're running in numa mode, set our memory node */
>  	if (par->node != -1)
> @@ -620,7 +621,8 @@ void *timerthread(void *param)
>  	if (par->cpu != -1) {
>  		CPU_ZERO(&mask);
>  		CPU_SET(par->cpu, &mask);
> -		if(sched_setaffinity(0, sizeof(mask), &mask) == -1)
> +		thread = pthread_self();
> +		if(pthread_setaffinity_np(thread, sizeof(mask), &mask) == -1)
>  			warn("Could not set CPU affinity to CPU #%d\n", par->cpu);
>  	}
>  
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel