From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: ipack: add support for IP-OCTAL mezzanine board
Date: Thu, 03 May 2012 11:39:04 +0200 [thread overview]
Message-ID: <4FA25238.8090902@igalia.com> (raw)
In-Reply-To: <20120503101513.2b2915ef@pyramind.ukuu.org.uk>
On 05/03/2012 11:15 AM, Alan Cox wrote:
> On Thu, 3 May 2012 09:47:47 +0200
> Samuel Iglesias Gonsalvez <siglesias@igalia.com> wrote:
>
>> IP-OCTAL is a 8-channels serial port device. There are several models
one per
>> each standard: RS-232, RS-422, RS-485.
>>
>> This driver can manage all of them.
>
> What are the plans for cleaning up this set of patches ?
>
Fix the wrong stuff in the needed iterations before they reach staging.
I can work on it the following weeks.
Looking at your comments, at least this patch needs more love before
being accepted in staging. I will work on it and send them again
including the suggestions of the other patches.
[...]
>
> Can't really comment on the bus stuff, but the tty driver looks mostly
> ok. It just needs a bit of modernising, and apart from that, and the
> locking issue on write looks pretty good.
Thanks,
Sam
next prev parent reply other threads:[~2012-05-03 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 7:47 [PATCH 0/3] add support for IndustryPack devices Samuel Iglesias Gonsalvez
2012-05-03 7:47 ` [PATCH 1/3] Staging: IndustryPack bus for the Linux Kernel Samuel Iglesias Gonsalvez
2012-05-03 7:47 ` [PATCH 2/3] Staging: ipack: added support for the TEWS TPCI-200 carrier board Samuel Iglesias Gonsalvez
2012-05-03 7:47 ` [PATCH 3/3] Staging: ipack: add support for IP-OCTAL mezzanine board Samuel Iglesias Gonsalvez
2012-05-03 9:15 ` Alan Cox
2012-05-03 9:39 ` Samuel Iglesias Gonsálvez [this message]
2012-05-03 15:32 ` [PATCH 0/3] add support for IndustryPack devices Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA25238.8090902@igalia.com \
--to=siglesias@igalia.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.