From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: git@vger.kernel.org, mmueller@vigilantsw.com,
Matthieu.Moy@grenoble-inp.fr, gitster@pobox.com
Subject: Re: [PATCH] git cherry-pick: Add NULL check to sequencer parsing of HEAD
Date: Thu, 03 May 2012 14:26:46 +0200 [thread overview]
Message-ID: <4FA27986.7010502@lsrfire.ath.cx> (raw)
In-Reply-To: <20120503120857.GA3085@hmsreliant.think-freely.org>
Am 03.05.2012 14:08, schrieb Neil Horman:
>>> + if (parse_commit(head_commit))
>>> return error(_("could not parse commit %s\n"),
>>> sha1_to_hex(head_commit->object.sha1));
>>
>> Note: parse_commit() can handle NULL, and it already reports error
>> details itself.
> No, it doesn't. parse_commit checks NULL already, true, but it just returns -1.
> No error message is provided to the user
Sorry, was too terse again: It handles NULL, without printing anything.
And it reports details for (other) errors. So you could return -1 if
parse_commit() returns non-zero and be done with it. Just saying.
René
next prev parent reply other threads:[~2012-05-03 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 11:20 [PATCH] git cherry-pick: Add NULL check to sequencer parsing of HEAD Neil Horman
2012-05-03 11:45 ` René Scharfe
2012-05-03 12:08 ` Neil Horman
2012-05-03 12:26 ` René Scharfe [this message]
2012-05-03 12:10 ` [PATCH v2] " Neil Horman
2012-05-03 14:09 ` [PATCH v3] " Neil Horman
2012-05-03 16:48 ` Matthieu Moy
2012-05-03 17:13 ` Junio C Hamano
[not found] ` <7vsjfhfbko.fsf@alter.siamese.dyndns.org>
2012-05-03 17:34 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA27986.7010502@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mmueller@vigilantsw.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.