From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0BCA9E00723 for ; Thu, 3 May 2012 05:40:19 -0700 (PDT) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id q43CeHK2002072 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 3 May 2012 05:40:17 -0700 (PDT) Received: from [128.224.208.134] (128.224.208.134) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.1.255.0; Thu, 3 May 2012 05:40:17 -0700 Message-ID: <4FA27CAF.8020205@windriver.com> Date: Thu, 3 May 2012 08:40:15 -0400 From: Bruce Ashfield User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: References: In-Reply-To: Cc: yocto@yoctoproject.org, dvhart@linux.intel.com Subject: Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2012 12:40:19 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote: > From: Tom Zanussi > > This adds a few new features, one for xhci-hcd and another for > amt/mei, and refactors some existing config options into a new > echi-hcd, which is then used in crownbay. > > If this looks like the way to go, I'll add similar USB features > for ohci and uhci and fix up all the meta-intel BSPs to use > them. I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable. I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/. I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ? But definitely, this is the way to go, just a minor question about the organization of the files. Bruce > > Please pull into linux-yocto-3.2. > > Thanks, > > Tom > > The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d: > Yang Shi (1): > meta: Clean up BSPs kernel config > > are available in the git repository at: > > git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features > http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features > > Tom Zanussi (5): > meta: add usb/host/base feature > meta: add usb/xhci-hcd feature > meta: add usb/ehci-hcd feature > meta/crownbay: use ehci-hcd feature > meta: add mei feature > > meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg | 4 ---- > meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc | 2 ++ > meta/cfg/kernel-cache/features/amt/mei/mei.cfg | 3 +++ > meta/cfg/kernel-cache/features/amt/mei/mei.scc | 4 ++++ > .../features/usb/ehci-hcd/ehci-hcd.cfg | 1 + > .../features/usb/ehci-hcd/ehci-hcd.scc | 6 ++++++ > meta/cfg/kernel-cache/features/usb/host/base.cfg | 3 +++ > meta/cfg/kernel-cache/features/usb/host/base.scc | 4 ++++ > .../features/usb/xhci-hcd/xhci-hcd.cfg | 1 + > .../features/usb/xhci-hcd/xhci-hcd.scc | 6 ++++++ > 10 files changed, 30 insertions(+), 4 deletions(-) > create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg > create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc > create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg > create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc > create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg > create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc > create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg > create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc >