From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SPy6m-0001NL-F7 for mharc-grub-devel@gnu.org; Thu, 03 May 2012 11:38:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPy6j-0001NA-OC for grub-devel@gnu.org; Thu, 03 May 2012 11:38:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPy6e-0004AB-OE for grub-devel@gnu.org; Thu, 03 May 2012 11:38:17 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:49962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPy6e-00049x-FD for grub-devel@gnu.org; Thu, 03 May 2012 11:38:12 -0400 Received: by wgbds1 with SMTP id ds1so1419939wgb.30 for ; Thu, 03 May 2012 08:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=M7EtH8ZKF264t6VTokgXmLEKSJC6MzRJx7ommxufZ50=; b=SIJckBCj/UCUdGMGLcQIQn3WOpRiFJQqw8+PFxSWPLAUtGunjChpqCWIr+URL/aeAD GbLdzGAKAx9bdvshTXqIEjiTdccHEVfu6fIsMP1j4274Y4AijsCgGNQWueye5WIuFxUR 4kGCAhwbD+AGPuPMoQ6zTkN8GWormLV3BVQcy1LpcnFKe7yk3F8ykGKKuQo0zK+mbhUj zyAaq99tpBZVNtNSeo6LhW8QAx4Aav9W4ZKiTWwJEQ0IA+yIC4qjmWNIUyjZueneUisP +n3zozbD3CURaMMzSc95IyFkHEVQFo6MTq4/Z09PY1tHXPKWu4w2Atv8WzntymZHTg/T gP/Q== Received: by 10.216.143.154 with SMTP id l26mr1708623wej.86.1336059490457; Thu, 03 May 2012 08:38:10 -0700 (PDT) Received: from debian.x201.phnet (public-docking-hg-4-235.ethz.ch. [129.132.244.235]) by mx.google.com with ESMTPS id e8sm462673wiy.3.2012.05.03.08.38.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 May 2012 08:38:09 -0700 (PDT) Message-ID: <4FA2A65F.40808@gmail.com> Date: Thu, 03 May 2012 17:38:07 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] bug fix for efi network References: In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig766E94BB7D4F15057713718B" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2012 15:38:19 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig766E94BB7D4F15057713718B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.04.2012 17:05, Bean wrote: > + for (i =3D 0; i < 3; i++) > { > + grub_uint64_t limit_time; =20 > + =20 > + efi_call_3 (net->get_status, net, &int_status, 0); > + > + limit_time =3D grub_get_time_ms () + 5; > + for (;;) > + { > + st =3D efi_call_7 (net->transmit, net, 0, (pack->tail - pack->data)= , > + pack->data, NULL, NULL, NULL); > + if (st !=3D GRUB_EFI_NOT_READY) > + break; > + > + if (limit_time < grub_get_time_ms ()) > + { > + st =3D GRUB_EFI_TIMEOUT; > + break; > + } > + } > + > + if (st) > + goto quit; > + > void *txbuf =3D NULL; > - st =3D efi_call_3 (net->get_status, net, 0, &txbuf); > - if (st !=3D GRUB_EFI_SUCCESS) > - return grub_error (GRUB_ERR_IO, N_("couldn't send network packet")); > - if (txbuf) > - return GRUB_ERR_NONE; > - if (limit_time < grub_get_time_ms ()) > - return grub_error (GRUB_ERR_TIMEOUT, N_("couldn't send network packet= ")); > + limit_time =3D grub_get_time_ms () + 5; > + for (;;) > + { =20 > + st =3D efi_call_3 (net->get_status, net, &int_status, &txbuf); > + > + if (txbuf !=3D NULL) > + break; > + > + if (limit_time < grub_get_time_ms ()) > + { > + st =3D GRUB_EFI_TIMEOUT; > + break; > + } > + } > + > + quit: > + if (st !=3D GRUB_EFI_TIMEOUT) > + break; > } > + > + return st; > } I see no justification as to why this part of patch so I can't know if it's something which is we absolutely need to commit or something that can wait. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig766E94BB7D4F15057713718B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+ipl8ACgkQNak7dOguQgmh6gD/VSLZHCLPdhE4k/26tn5EAs1q oLOjuUd01NzOuvgTmJoA/ie1q8QmfpK2QlX/X/i3+r1Ur3oel7ZFhJ5s+DEWaXxx =PPRv -----END PGP SIGNATURE----- --------------enig766E94BB7D4F15057713718B--