From: Joshua Roys <Joshua.Roys@gtri.gatech.edu>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/9] rtlwifi: fix the selection of the bulk in endpoint
Date: Thu, 3 May 2012 12:47:40 -0400 [thread overview]
Message-ID: <4FA2B6AC.4060800@gtri.gatech.edu> (raw)
In-Reply-To: <4FA2AD36.3010005@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On 05/03/2012 12:07 PM, Larry Finger wrote:
> On 05/03/2012 12:11 AM, Joshua Roys wrote:
>
> I am still reviewing the patches; however, the build fails after this
> patch with
>
> CC [M] drivers/net/wireless/rtlwifi/rtl8192cu/trx.o
> drivers/net/wireless/rtlwifi/rtl8192cu/trx.c: In function
> ‘rtl8192cu_endpoint_mapping’:
> drivers/net/wireless/rtlwifi/rtl8192cu/trx.c:206:27: error: ‘usb_priv’
> undeclared (first use in this function)
> drivers/net/wireless/rtlwifi/rtl8192cu/trx.c:206:27: note: each
> undeclared identifier is reported only once for each function it appears in
> make[2]: *** [drivers/net/wireless/rtlwifi/rtl8192cu/trx.o] Error 1
> make[1]: *** [drivers/net/wireless/rtlwifi/rtl8192cu] Error 2
> make: *** [drivers/net/wireless/rtlwifi/] Error 2
>
> You are missing a
>
> struct rtl_usb_priv *usb_priv = rtl_usbpriv(hw);
>
> ahead of line 206.
>
> I also had some compilation problems with patch 9. The problem there was
> that you are basing your changes on the wrong tree. All changes to
> wireless drivers should be from the wireless-testing git tree at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git
>
> and not from the mainline tree.
>
> Larry
OK, thanks. I'll rebase them all later tonight.
Josh
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5046 bytes --]
next prev parent reply other threads:[~2012-05-03 16:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 5:08 [WIP] rtlwifi: rtl8192su subdriver Joshua Roys
2012-05-03 5:10 ` [PATCH 1/9] rtlwifi: avoid race registering with mac80211 Joshua Roys
2012-05-03 17:10 ` Larry Finger
2012-05-03 17:21 ` Joshua Roys
2012-05-03 18:55 ` Larry Finger
2012-05-03 5:10 ` [PATCH 2/9] rtlwifi: don't pass a null pointer to fill_tx_desc Joshua Roys
2012-05-03 5:11 ` [PATCH 3/9] rtlwifi: fix typo Joshua Roys
2012-05-03 5:11 ` [PATCH 4/9] rtlwifi: fix the selection of the bulk in endpoint Joshua Roys
2012-05-03 16:07 ` Larry Finger
2012-05-03 16:47 ` Joshua Roys [this message]
2012-05-03 5:12 ` [PATCH 5/9] rtlwifi: check for all 8192Sx-family cards for efuse operations Joshua Roys
2012-05-03 5:12 ` [PATCH 6/9] rtlwifi: add short circuit in the receive path Joshua Roys
2012-05-03 5:13 ` [PATCH 7/9] rtlwifi: fail rtl_usb_start if any bulk in urbs fail Joshua Roys
2012-05-03 5:13 ` [PATCH 8/9] rtlwifi: ugly hack to enable feature disparity between subdrivers Joshua Roys
2012-05-03 5:15 ` [PATCH 9/9] [WIP] rtlwifi: add rtl8192su subdriver Joshua Roys
2012-05-08 2:18 ` [WIP v2] rtlwifi: " Joshua Roys
2012-05-08 2:18 ` [PATCH 1/9] rtlwifi: don't pass a null pointer to fill_tx_desc Joshua Roys
2012-05-08 2:18 ` [PATCH 2/9] rtlwifi: fix typo Joshua Roys
2012-05-08 2:18 ` [PATCH 3/9] rtlwifi: fix the selection of the bulk in endpoint Joshua Roys
2012-05-08 2:18 ` [PATCH 4/9] rtlwifi: check for all 8192Sx-family cards for efuse operations Joshua Roys
2012-05-08 2:18 ` [PATCH 5/9] rtlwifi: add short circuit in the receive path Joshua Roys
2012-05-08 2:18 ` [PATCH 6/9] rtlwifi: fail rtl_usb_start if any bulk in urbs fail Joshua Roys
2012-05-08 2:18 ` [PATCH 7/9] rtlwifi: mimic rtl_pci_stop and disable LEDs Joshua Roys
2012-05-08 2:18 ` [PATCH 8/9] rtlwifi: ugly hack to enable feature disparity between subdrivers Joshua Roys
2012-05-08 2:18 ` [PATCH 9/9] rtlwifi: add rtl8192su subdriver Joshua Roys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA2B6AC.4060800@gtri.gatech.edu \
--to=joshua.roys@gtri.gatech.edu \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.