From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition Date: Thu, 03 May 2012 13:36:05 -0400 Message-ID: <4FA2C205.3030801@teksavvy.com> References: <1335953452-10460-1-git-send-email-jack@suse.cz> <4FA1092E.9090603@redhat.com> <20120502115447.7dcc3a54@pyramind.ukuu.org.uk> <4FA11454.2010103@redhat.com> <20120502121208.3c19a9bc@pyramind.ukuu.org.uk> <4FA11963.3040007@redhat.com> <4FA18D33.3060607@teksavvy.com> <4FA23809.2090905@redhat.com> <4FA27CDB.2080103@teksavvy.com> <4FA27E7C.6070802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FA27E7C.6070802@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Paolo Bonzini Cc: Alan Cox , Jan Kara , Jens Axboe , LKML , James Bottomley , linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 12-05-03 08:47 AM, Paolo Bonzini wrote: > Il 03/05/2012 14:40, Mark Lord ha scritto: >>>> >>>> Breaking "hdparm --write-sector /dev/sda1"? I call it a security fix. >> No, that would plain stupid on both our parts. :) >> The --write-sector flag is allowed only for non-partitions by hdparm itself. > > Excuse my laziness--how does it check? I don't know if there's a feasible fool-proof method or not. But what hdparm does is look at the sector offset of the device. Partitions normally have a non-zero offset. >> But other flags commonly used by distros at boot time >> seem to be triggering the current in-kernel noise. >> Dunno which flags, I'm just ignoring them and waiting >> for the noise message to get reverted. > > That's exactly the behavior I hoped to get when I added the warnings. > Or maybe not. :) What are the messages? > i.e. what ioctl do they complain about? As above: >> Dunno which flags, I'm just ignoring them and waiting >> for the noise message to get reverted.