From: Deng-Cheng Zhu <dczhu@mips.com>
To: Tom Herbert <therbert@google.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<eric.dumazet@gmail.com>
Subject: Re: [PATCH v2] RPS: Sparse connection optimizations - v2
Date: Fri, 4 May 2012 12:25:33 +0800 [thread overview]
Message-ID: <4FA35A3D.8000205@mips.com> (raw)
In-Reply-To: <CA+mtBx_J=fm3+k6_NzMH9KCdrYpZPwT2XBQe4r424eNDCKzazg@mail.gmail.com>
On 05/04/2012 11:22 AM, Tom Herbert wrote:
>> +struct cpu_flow {
>> + struct net_device *dev;
>> + u32 rxhash;
>> + unsigned long ts;
>> +};
>
> This seems like overkill, we already have the rps_flow_table and this
> used in accelerated RFS so the device can also take advantage of
> steering.
I think the mechanisms of rps_dev_flow_table and cpu_flow (in this
patch) are different: The former works along with rps_sock_flow_table
whose CPU info is based on recvmsg by the application. But for the tests
like what I did, there's no application involved.
Deng-Cheng
next prev parent reply other threads:[~2012-05-04 4:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 8:56 [PATCH v2] RPS: Sparse connection optimizations - v2 Deng-Cheng Zhu
2012-05-04 3:22 ` Tom Herbert
2012-05-04 3:39 ` Deng-Cheng Zhu
2012-05-04 4:25 ` Deng-Cheng Zhu [this message]
2012-05-04 7:47 ` Eric Dumazet
2012-05-07 6:51 ` Deng-Cheng Zhu
2012-05-07 7:22 ` Eric Dumazet
2012-05-04 15:31 ` Tom Herbert
2012-05-04 15:47 ` Eric Dumazet
2012-05-04 20:53 ` Eric Dumazet
2012-05-07 6:48 ` Deng-Cheng Zhu
2012-05-07 7:38 ` Eric Dumazet
2012-05-07 8:01 ` Deng-Cheng Zhu
2012-05-07 8:25 ` Eric Dumazet
2012-05-08 6:43 ` Deng-Cheng Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA35A3D.8000205@mips.com \
--to=dczhu@mips.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.