From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Subject: Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue Date: Fri, 04 May 2012 09:03:02 +0300 Message-ID: <4FA37116.4020608@compulab.co.il> References: <1332139367-1302-1-git-send-email-keshava_mgowda@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russ Dill Cc: "Raja, Govindraj" , Keshava Munegowda , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi Russ, On 05/03/12 22:08, Russ Dill wrote: > On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj wrote: >> On Wed, May 2, 2012 at 2:17 PM, Russ Dill wrote: >>> On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj wrote: >>>> On Mon, Mar 19, 2012 at 12:12 PM, Keshava Munegowda >>>> wrote: >>>>> From: Keshava Munegowda >>>>> >>>>> It is observed that the echi ports of 3430 sdp board >>>>> are not working due to the random timing of programming >>>>> the associated GPIOs of the ULPI PHYs of the EHCI for reset. >>>>> If the PHYs are reset at during usbhs core driver, host ports will >>>>> not work because EHCI driver is loaded after the resetting PHYs. >>>>> The PHYs should be in reset state while initializing the EHCI >>>>> controller. >>>>> The code which does the GPIO pins associated with the PHYs >>>>> are programmed to reset is moved from the USB host core driver >>>>> to EHCI driver. >>>> >>>> I tested on beagle xm where gpio nreset is requested from >>>> board file. >>>> (Basic enumertaion after gpio nreset seems to work fine, >>>> Hub and smsc lan chip get detected afetr boot up) >>>> >>> >>> What base did you test this on top of? my xM is failing USB-wise when >>> I apply this on v3.3.3 (with the UART mux fix patch) and where it is >>> applied within master (3.4-rc4, again, with the UART mux fix patch). >>> Additionally, reverting this patch from 3.4-rc5 causes rc5 to work >>> properly. >>> >> >> Works for me be on 3.4-rc5 Beagle-XM even without reverting the patch >> >> Logs as in here [1]. >> >> -- >> Thanks, >> Govindraj.R >> >> [1]: >> http://pastebin.pandaboard.org/index.php/view/20343533 > > I've tracked down the difference. I'm loading my uEnv.txt and uImage > in u-boot from the network which means initializing USB. You are > loading straight from MMC. If I switch to loading straight from MMC > everything works. > > Can everyone do a 'usb start' in u-boot before booting and re-test? > I'm pretty sure this is a regression, but the bug could be a strange > u-boot/kernel interaction. Probably, kernel code does not reinitialize EHCI correctly if it was already enabled? Can you try the below sequence: usb start usb stop boot Linux ? -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html