From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SQBgV-0005i5-8q for mharc-grub-devel@gnu.org; Fri, 04 May 2012 02:08:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQBgS-0005h6-HQ for grub-devel@gnu.org; Fri, 04 May 2012 02:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQBgN-0000FD-Jo for grub-devel@gnu.org; Fri, 04 May 2012 02:08:04 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:55543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQBgN-0000Ey-Ar for grub-devel@gnu.org; Fri, 04 May 2012 02:07:59 -0400 Received: by werb14 with SMTP id b14so983743wer.0 for ; Thu, 03 May 2012 23:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=lrrE6rOHVQNyLHq39LMGWTUuwrFkAosUtCEHUJeSLtc=; b=QjsYLndRYjO80yrm8Us3W0N1mK87i/k5ZhDxBpooZqAM4+/Y7COGWuSGdkgk60qP0F cfU8IKdApDP9QTDqVKkuVMmb/HhFJPnIxzmMDBCyoMRKC3vvlT2v7b0ZyU1u0VB1VavV pVXFqlg5yxyeQgy50Pstp2xFyZ44y1o72xq8keyLjI9yf0PHddR+JWlQQanx3NDoWTJj W3Yv2i6BG/1SrAq+ovBDrlDId8Nx8Xb/xEBXKzUibt0bGjpTFaXIqbVFg8kgXoYrSUxN pbgIWtuEaiMNL6UzZt7rovPVgiAIg0yA7vcys+S5FpTVCz39mmMKMr6HSXHZjzebYSpV MdpA== Received: by 10.216.135.141 with SMTP id u13mr3032296wei.79.1336111677060; Thu, 03 May 2012 23:07:57 -0700 (PDT) Received: from debian.x201.phnet (93-234.197-178.cust.bluewin.ch. [178.197.234.93]) by mx.google.com with ESMTPS id 6sm2418334wiz.1.2012.05.03.23.07.55 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 May 2012 23:07:55 -0700 (PDT) Message-ID: <4FA37235.8030608@gmail.com> Date: Fri, 04 May 2012 08:07:49 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] network mega patch References: <4FA2DC5E.4050708@gmail.com> <4FA2E198.6060900@gmail.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig289F1C6238D4FDFAEF1322E0" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 06:08:06 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig289F1C6238D4FDFAEF1322E0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04.05.2012 05:43, Bean wrote: > On Fri, May 4, 2012 at 3:50 AM, Vladimir '=CF=86-coder/phcoder' Serbine= nko > wrote: >> On 03.05.2012 21:40, Bean wrote: >>> + if (rsm->asm_netbuff) >>> + grub_netbuff_free (rsm->asm_netbuff); >> Could you make grub_netbuff_free skip on NULL and so simplify it here= ? > Hi, > > I think this is one of the few place where netbuff can be NULL (it > usually return error when grub_netbuff_alloc return NULL), since > grub_netbuff_free is called a lot, it might have a little performance > impact when we do the check in grub_netbuff_free. It's not called that much that this additional check would be a performance hit. But it decreases the probability of similar bugs to essentially zero. >> When you've done this you can commit bug.diff. >> Thank you >> >> -- >> Regards >> Vladimir '=CF=86-coder/phcoder' Serbinenko >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig289F1C6238D4FDFAEF1322E0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+jcjUACgkQNak7dOguQgloKAD/Ynfsk8BIUI5z7JmvI0Sm8tUh LSMQoVndA8fvrT4HFNIA/0X3rViiYgAudQ3puZ82JYtqAxgF5QFnySqEDldT2Dov =xsBM -----END PGP SIGNATURE----- --------------enig289F1C6238D4FDFAEF1322E0--