From: Karsten Keil <kkeil@linux-pingi.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, isdn@linux-pingi.de
Subject: Re: [PATCHv2 4/7] mISDN: Make layer1 timer 3 value configurable
Date: Fri, 04 May 2012 08:47:09 +0200 [thread overview]
Message-ID: <4FA37B6D.3070001@linux-pingi.de> (raw)
In-Reply-To: <20120503.170830.1574473660496726919.davem@davemloft.net>
Am 03.05.2012 23:08, schrieb David Miller:
> From: Karsten Keil <kkeil@linux-pingi.de>
> Date: Thu, 3 May 2012 17:47:29 +0200
>
>> @@ -372,6 +372,7 @@ clear_channelmap(u_int nr, u_char *map)
>> #define MISDN_CTRL_RX_OFF 0x0100
>> #define MISDN_CTRL_FILL_EMPTY 0x0200
>> #define MISDN_CTRL_GETPEER 0x0400
>> +#define MISDN_CTRL_L1_TIMER3 0x0800
>> #define MISDN_CTRL_HW_FEATURES_OP 0x2000
>> #define MISDN_CTRL_HW_FEATURES 0x2001
>> #define MISDN_CTRL_HFC_OP 0x4000
>
> This define is completely unused by this patch.
>
> To say that I'm frustrated by this process would be an understatement.
>
>
It is used in the next patch of the series. I usually make different
patches for core infrastructure changes and the low level driver changes.
If you think it would be better to do this in one patch - I can provide
a new series.
Karsten
next prev parent reply other threads:[~2012-05-04 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 15:47 [PATCHv2 0/7] mISDN: Collection of patches for layer1/layer2 Karsten Keil
2012-05-03 15:47 ` [PATCHv2 1/7] mISDN: Added PH_* state info to tei manager Karsten Keil
2012-05-03 15:47 ` [PATCHv2 2/7] mISDN: Fix refcounting bug Karsten Keil
2012-05-03 15:47 ` [PATCHv2 3/7] mISDN: L2 timeouts need to be queued as L2 event Karsten Keil
2012-05-03 15:47 ` [PATCHv2 4/7] mISDN: Make layer1 timer 3 value configurable Karsten Keil
2012-05-03 21:08 ` David Miller
2012-05-04 6:47 ` Karsten Keil [this message]
2012-05-03 15:47 ` [PATCHv2 5/7] Add L1 timer3 config control to lowlevel drivers Karsten Keil
2012-05-03 15:47 ` [PATCHv2 6/7] mISDN: Layer1 statemachine fix Karsten Keil
2012-05-03 15:47 ` [PATCHv2 7/7] mISDN: Help to identify the card Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA37B6D.3070001@linux-pingi.de \
--to=kkeil@linux-pingi.de \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.