From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQDXI-0003Gu-0P
	for qemu-devel@nongnu.org; Fri, 04 May 2012 04:06:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQDXB-0000Vt-Ti
	for qemu-devel@nongnu.org; Fri, 04 May 2012 04:06:43 -0400
Received: from mail-pz0-f44.google.com ([209.85.210.44]:58611)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQDXB-0000Td-LH
	for qemu-devel@nongnu.org; Fri, 04 May 2012 04:06:37 -0400
Received: by dacx6 with SMTP id x6so2911613dac.31
	for <qemu-devel@nongnu.org>; Fri, 04 May 2012 01:06:34 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FA38E01.1050301@redhat.com>
Date: Fri, 04 May 2012 10:06:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1335248944-10765-1-git-send-email-ronniesahlberg@gmail.com>
	<1335248944-10765-2-git-send-email-ronniesahlberg@gmail.com>
In-Reply-To: <1335248944-10765-2-git-send-email-ronniesahlberg@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning
 via discard/UNMAP and bigger LUNs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto:
> +    itask->bs->total_sectors    = rc16->returned_lba *
> +                               rc16->block_length / BDRV_SECTOR_SIZE ;

Ronnie, does this need to be "(rc16->returned_lba + 1) * ..."?

READ CAPACITY returns the highest valid LBA, not the size.

Please send a patch to fix this up if that's the case.

Paolo