From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SQJ98-0005SD-BR
	for qemu-devel@nongnu.org; Fri, 04 May 2012 10:06:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SQJ91-00049F-D5
	for qemu-devel@nongnu.org; Fri, 04 May 2012 10:06:09 -0400
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:54740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SQJ90-00048T-N3
	for qemu-devel@nongnu.org; Fri, 04 May 2012 10:06:03 -0400
Received: from /spool/local
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 4 May 2012 15:06:00 +0100
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q44E5u592584656
	for <qemu-devel@nongnu.org>; Fri, 4 May 2012 15:05:56 +0100
Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q44E5S22014661
	for <qemu-devel@nongnu.org>; Fri, 4 May 2012 08:05:28 -0600
Message-ID: <4FA3E21B.5030303@de.ibm.com>
Date: Fri, 04 May 2012 16:05:15 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <4EC02384-64EF-4514-975C-A3D229B3693E@suse.de>
	<1336055277-53204-1-git-send-email-borntraeger@de.ibm.com>
	<CAFEAcA_w9AbTB_93ehMMRb9UDKiM3UEToTQgLHX6cRQsbA-juA@mail.gmail.com>
In-Reply-To: <CAFEAcA_w9AbTB_93ehMMRb9UDKiM3UEToTQgLHX6cRQsbA-juA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys
 to accept max_size > INT_MAX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, agraf@suse.de, QEMU Developers <qemu-devel@nongnu.org>

>> Since load_image_targphys is declared as taking an int for max_sz, this will
>> fail for ram sizes > INT_MAX.
>> Lets change the max_sz parameter to a uint64_t.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> A patch equivalent to this has already been submitted:
>   http://patchwork.ozlabs.org/patch/146165/
> We should be applying that one, it has already been reviewed.

Right.

> 
> Anthony?

AFAIK Anthony is on holiday. It would be good, if we could have that before 1.1, so shall
we wait or are there other maintainers willing to accept that patch?

Christian